-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Management] Push log level downstream #22815
[Ingest Management] Push log level downstream #22815
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Should we have tests for this? |
@EricDavisX @rahulgupta-qasource This should be available soon see linked issues for endpoint support. |
Hi @EricDavisX We have created 03 testcases for this ticket and linked ticket #20756 . testcases links are as follows: However, we have 01 query at information provided on point below at #8105 Could you please confirm where we could locate this file and verify the same. |
@dikshachauhan-qasource I believe... you shouldn't see a difference there, it was an internal refactor to make the logging come out right. If the Endpoint logs show up, and have policy items displayed - then it is working. |
[Ingest Management] Push log level downstream (elastic#22815)
Hi @EricDavisX We have validated this ticket on 8.0.0 snapshot cloud environment as per code commit in elastic/kibana@62e79ee and found that code for same is not merged. Below are the build details:
Steps to reproduce:
Observation: logging level is not displayed under fleet section of default policy. Screenshot: |
@dikshachauhan-qasource Hi. I think the commit yesterday morning missed the Tuesday build, and the Wednesday build isn't 'done' yet by the time you were testing. So, let us re-test tomorrow. I wish we had a better mechanism for tracking check-ins to when they are available in SNAPSHOT builds. I don't know of one better than tracing in git and correlating against the Jenkins jobs for the build for the branch in question, tho we can always do that. The good news is that for many tests, we can use the Observability generated artifacts. I think @rahulgupta-qasource knows of those, so please follow up with him. I will confirm in our sync tomorrow too. Final comment... I don't expect the Agent policy that the Agent is assigned to would show the log-level change. I'll ask @michalpristas to help confirm, please. I think we should lay out some AC for the expectation here in terms of precedence:
|
Hi @EricDavisX We have executed 05 testcases under test plan Push log level downstream Test Run Build details are as follows:
Please let us know if anything is required from our side. Thanks |
What does this PR do?
This PR injects log level settings into fleet section of config as discussed in linked issue.
resulting config will look like this
Why is it important?
#20756
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.cc @ph @ferullo