use environment variables in install-service.ps1 template #22874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
leehinman
added
libbeat
needs_backport
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
- replace hard coded C:\ProgramData with $env:PROGRAMDATA
leehinman
force-pushed
the
596_ps1_use_env_variables
branch
from
b7aff56
to
9080177
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 16760 |
| Skipped | 1373 |
| Total | 18133 |
andrewkroh
approved these changes
Dec 2, 2020
3 tasks
leehinman
added
v7.11.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 3, 2020
) - replace hard coded C:\ProgramData with $env:PROGRAMDATA (cherry picked from commit 3910e8b)
leehinman
added a commit
that referenced
this pull request
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
C:\ProgramDatawith environment variable env:PROGRAMDATA inthe install-service.ps1 scripts.
Why is it important?
Follows best practice for determining locations on Windows.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
run
install-service.ps1on Windows machine