-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Deprecate Gsuite module and create Google Workspace one #22950
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
85859aa
to
109f251
Compare
@marc-gr does this incorporate the changes from the |
I updated it with the changes in Gsuite 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good to me, just a couple nits about the docs. It'll be good to have someone else looking at it, though.
@@ -12,6 +12,8 @@ This file is generated! See scripts/docs_collector.py | |||
|
|||
beta[] | |||
|
|||
*Gsuite module is deprecated and will be removed in future releases. Please use Google Workspace module instead.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here we can use a deprecated::[X.Y.Z]
tag (see docs)
|
||
beta[] | ||
|
||
This is a module for ingesting data from the different Google Workspace audit reports API's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a module for ingesting data from the different Google Workspace audit reports API's. | |
This is a module for ingesting data from the different Google Workspace audit reports APIs. |
…lastic#22950) * Deprecate Gsuite module and create Google Workspace one * Update with latest gsuite changes * Use deprecation tag and fix doc typo (cherry picked from commit 4540460)
What does this PR do?
gsuite
togoogle_workspace
)Why is it important?
To be aligned with new Google rebranding from GSuite to Google Workspace.
To prevent users custom rules to break on the module renaming, we decided to duplicate it for a release while they migrate to the new one, instead of directly doing a rename which would be a breaking change.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues