[Filebeat] Fix dissect pattern for Cisco WebVPN message 716002 #22966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern. Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918
andrewkroh
force-pushed
the
bugfix/fb/cisco-asa-webvpn-dissect
branch
from
8693f7f
to
c16bc4c
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leehinman
reviewed
Dec 9, 2020
| @@ -546,7 +546,7 @@ processors: | |||
| - dissect: | |||
| if: "ctx._temp_.cisco.message_id == '716002'" | |||
| field: "message" | |||
| pattern: "Group %{} User %{source.user.name} IP %{source.address} WebVPN session terminated: User Requested." | |||
| pattern: "Group %{} User %{source.user.name} IP %{source.address} WebVPN session terminated: %{}" | |||
There was a problem hiding this comment.
any value in mapping this to event.reason?
There was a problem hiding this comment.
That sounds good. I was looking for a field to put this into.
leehinman
approved these changes
Dec 9, 2020
andrewkroh
added
the
needs_backport
Merged
3 tasks
andrewkroh
removed
the
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Dec 15, 2020
…ic#22966) The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern. Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918 (cherry picked from commit 6955f81)
andrewkroh
added a commit
that referenced
this pull request
Dec 15, 2020
… (#23131) The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern. Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918 (cherry picked from commit 6955f81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern.
Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918
Why is it important?
The module was failing to parse some WebVPN log messages.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.