Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Winlogbeat] Use ingress/egress instead of inbound/outbound #22997

Merged
merged 2 commits into from
Dec 9, 2020
Merged

[Winlogbeat] Use ingress/egress instead of inbound/outbound #22997

merged 2 commits into from
Dec 9, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Dec 8, 2020 •
edited
Loading

What does this PR do?

This changes the sysmon module to use the new ECS 1.7 host-centric ingress/egress values.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki requested a review from a team December 8, 2020 21:49
@andrewstucki andrewstucki requested a review from a team as a code owner December 8, 2020 21:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 8, 2020
@andrewstucki andrewstucki mentioned this pull request Dec 8, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 8, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22997 updated

  • Start Time: 2020-12-08T21:51:32.092+0000

  • Duration: 22 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

andrewkroh
andrewkroh approved these changes Dec 9, 2020
View reviewed changes
CHANGELOG.next.asciidoc Show resolved Hide resolved
@andrewstucki andrewstucki merged commit 12af688 into elastic:master Dec 9, 2020
@andrewstucki andrewstucki deleted the winlogbeat-ingress-egress branch December 9, 2020 01:57
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 9, 2020
[Winlogbeat] Use ingress/egress instead of inbound/outbound (elastic#…
aae8870 
…22997)

* [Winlogbeat] Use ingress/egress instead of inbound/outbound

* Add changelog entry

(cherry picked from commit 12af688)
@andrewstucki andrewstucki mentioned this pull request Dec 9, 2020
Merged
6 tasks
andrewstucki pushed a commit that referenced this pull request Dec 9, 2020
Cherry-pick #22997 to 7.x: [Winlogbeat] Use ingress/egress instead of…
a663a99 
… inbound/outbound (#23003)

* [Winlogbeat] Use ingress/egress instead of inbound/outbound (#22997)

* [Winlogbeat] Use ingress/egress instead of inbound/outbound

* Add changelog entry

(cherry picked from commit 12af688)

* Fix up changelog
@jsoriano jsoriano mentioned this pull request Dec 9, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
breaking change ecs enhancement v7.11.0 Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @andrewkroh