Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22974 to 7.x: Improve event normalization performance #23029

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

urso
Copy link

@urso urso commented Dec 9, 2020

Cherry-pick of PR #22974 to 7.x branch. Original message:

Enhancement

What does this PR do?

Improve event normalization performance

Why is it important?

generalize/normalize is widely used in beats

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Benchmark

Related issues

Use cases

Screenshots

Logs

$ benchstat old.txt new.txt                                                                              
name             old time/op    new time/op    delta
Normalization-8     984ns ±16%     559ns ±13%  -43.16%  (p=0.000 n=20+19)

name             old alloc/op   new alloc/op   delta
Normalization-8    1.18kB ± 0%    0.74kB ± 0%  -37.41%  (p=0.000 n=20+20)

name             old allocs/op  new allocs/op  delta
Normalization-8      13.0 ± 0%       5.0 ± 0%  -61.54%  (p=0.000 n=20+20)

@urso urso added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Dec 9, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23029 updated

  • Start Time: 2020-12-14T13:34:46.429+0000

  • Duration: 54 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 17385
Skipped 1404
Total 18789

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17385
Skipped 1404
Total 18789

newly12 and others added 2 commits December 14, 2020 14:32
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit d9d337c)
@urso urso merged commit 42c5abf into elastic:7.x Dec 14, 2020
@urso urso deleted the backport_22974_7.x branch December 14, 2020 21:34
@zube zube bot removed the [zube]: Done label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants