Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22877 to 7.x: [libbeat] Mark additional log metrics as gauges #23032

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Dec 9, 2020

Cherry-pick of PR #22877 to 7.x branch. Original message:

What does this PR do?

This marks additional log metrics as gauges.

libbeat.output.events.active and beat.memstats.rss are both gauges
(rather than counters) so disable delta reporting for these two values.

Why is it important?

It's really hard to make sense the metrics over time since they are reported as deltas.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh andrewkroh added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
`libbeat.output.events.active` and `beat.memstats.rss` are both gauges
(rather than counters) so disable delta reporting for these two values.

(cherry picked from commit 547d15d)
@andrewkroh andrewkroh requested a review from urso December 9, 2020 16:21
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23032 updated

  • Start Time: 2020-12-14T04:21:19.880+0000

  • Duration: 51 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 17385
Skipped 1404
Total 18789

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17385
Skipped 1404
Total 18789

@andrewkroh
Copy link
Member Author

run tests

@andrewkroh andrewkroh merged commit 9892811 into elastic:7.x Dec 14, 2020
@zube zube bot removed the [zube]: Done label Mar 14, 2021
@andrewkroh andrewkroh deleted the backport_22877_7.x branch January 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants