Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23066 to 7.x: [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones #23082

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Dec 10, 2020

Cherry-pick of PR #23066 to 7.x branch. Original message:

What does this PR do?

This adopts the same logic as #22998 by classifying internal/external/inbound/outbound traffic based off of zones.

It differs due to the fact that the checkpoint module (and the cef module when used with checkpoint) already fill in a network direction based off of a field in the actual event payload that says either "inbound" or "outbound". That said, this change would allow internal/external traffic classification and classifying logically based off of logical network segments in a partitioned network where some zones are considered inside of a DMZ v. outside.

By default the classification overriding is turned off.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…tionality based off of zones (elastic#23066)

* [Filebeat] Allow cef and checkpoint modules to override network directionality based off of zones

* Remove _temp_

* Add changelog entry

* run mage update and add variable reference

* Don't override categorization if no zone set

* Update cef pipeline

(cherry picked from commit f52e452)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 10, 2020
@andrewstucki andrewstucki requested a review from a team December 10, 2020 20:30
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 10, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23082 updated

  • Start Time: 2020-12-10T20:30:59.166+0000

  • Duration: 54 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 2412
Skipped 261
Total 2673

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2412
Skipped 261
Total 2673

@andrewstucki andrewstucki merged commit 09a664d into elastic:7.x Dec 10, 2020
@andrewstucki andrewstucki deleted the backport_23066_7.x branch December 10, 2020 21:50
@zube zube bot removed the [zube]: Done label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants