Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23045 to 7.x: Fix aws s3 overview dashboard #23128

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Cherry-pick #23045 to 7.x: Fix aws s3 overview dashboard #23128

merged 2 commits into from
Dec 15, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 14, 2020

Cherry-pick of PR #23045 to 7.x branch. Original message:

What does this PR do?

This PR is to fix AWS S3 overview dashboard and also improve documentation for both s3_daily_storage and s3_request metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 14, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 14, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23128 updated

  • Start Time: 2020-12-14T23:39:41.721+0000

  • Duration: 46 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 637
Skipped 70
Total 707

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 637
Skipped 70
Total 707

@kaiyan-sheng kaiyan-sheng merged commit 4ed2be5 into elastic:7.x Dec 15, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_23045_7.x branch December 15, 2020 00:40
@zube zube bot removed the [zube]: Done label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants