Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws-iso and aws-iso-b partition #23209

Closed
wants to merge 2 commits into from
Closed

add aws-iso and aws-iso-b partition #23209

wants to merge 2 commits into from

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 17, 2020

This PR adds aws-iso and aws-iso-b into the supported AWS partition list. Also added GetEndpoint function to assign DNS suffix endpoint based on the given AWS partition names.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 17, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 17, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 18, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23209 updated

  • Start Time: 2020-12-18T01:30:22.207+0000

  • Duration: 53 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 5457
Skipped 380
Total 5837

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5457
Skipped 380
Total 5837

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Dec 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 18, 2020
@kaiyan-sheng
Copy link
Contributor Author

We would like to remove all hardcoded switch cases. Will close this PR.

@kaiyan-sheng kaiyan-sheng deleted the aws_partition branch January 15, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants