Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23335 to 7.x: Fix types for response fields of kubelet api #23383

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 7, 2021

Cherry-pick of PR #23335 to 7.x branch. Original message:

What does this PR do?

This PR adjusts the types of the response fields from Kubelet stats/summary api so as to be consistent with the original types of the fields as defined on api's side: https://github.com/kubernetes/kubelet/blob/088ee84ea259bf9c445109ea75b2938dd39d2074/pkg/apis/stats/v1alpha1/types.go

Why is it important?

To avoid hitting integer overflow since we store as int64 while the api can serve values stored as uint64.
int64: -9223372036854775808 to 9223372036854775807
uint64: 0 to 18446744073709551615

Closes #19475

@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jan 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 7, 2021
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23383 updated

  • Start Time: 2021-01-07T08:33:24.814+0000

  • Duration: 54 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 2287
Skipped 505
Total 2792

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 14 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2287
Skipped 505
Total 2792

@ChrsMark ChrsMark merged commit 110333e into elastic:7.x Jan 7, 2021
@zube zube bot removed the [zube]: Done label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants