Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][httpjson] Allow for custom encoders and decoders #23478

Merged
merged 2 commits into from
Jan 14, 2021
Merged

[Filebeat][httpjson] Allow for custom encoders and decoders #23478

merged 2 commits into from
Jan 14, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jan 13, 2021

What does this PR do?

Allows to develop custom encoder/decoders for httpjson and the ability to force usage of a specific one.

Why is it important?

Will help for future development of supported formats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from a team January 13, 2021 09:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 13, 2021
@marc-gr marc-gr mentioned this pull request Jan 13, 2021
Closed
4 tasks
@marc-gr marc-gr force-pushed the encoding_poc branch 2 times, most recently from b8c303c to b82a020 Compare January 13, 2021 09:56
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 13, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23478 updated

    • Start Time: 2021-01-13T16:04:12.644+0000

  • Duration: 58 min 45 sec

  • Commit: 30052ba

Test stats 🧪

Test Results
Failed 0
Passed 5129
Skipped 574
Total 5703

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5129
Skipped 574
Total 5703

leehinman
leehinman approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll try implementing the form post & ndjson with this.

@marc-gr marc-gr merged commit 2d57928 into elastic:master Jan 14, 2021
@marc-gr marc-gr deleted the encoding_poc branch January 14, 2021 08:02
marc-gr added a commit to marc-gr/beats that referenced this pull request Jan 14, 2021
@marc-gr
[Filebeat][httpjson] Allow for custom encoders and decoders (elastic#…
1b41f93 
…23478)

* Allow for custom encoders and decoders

* Use transform and response for more flexible encode/decode operations

(cherry picked from commit 2d57928)
@marc-gr marc-gr mentioned this pull request Jan 14, 2021
Merged
6 tasks
marc-gr added a commit that referenced this pull request Jan 20, 2021
@marc-gr
[Filebeat][httpjson] Allow for custom encoders and decoders (#23478) (#…
b1e32c1 
…23495)

* Allow for custom encoders and decoders

* Use transform and response for more flexible encode/decode operations

(cherry picked from commit 2d57928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @leehinman