-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Support for linux/arm64 #23479
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
/Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Endpoint is not adding Linux ARM support for the time being. |
@jmlrt may I let you respond to PH's question |
Pinging @elastic/agent (Team:Agent) |
I looked into infra code @ph and there are changes which needs to be done yeah. this PR just makes sure agent is ok with arm, arm binary wont be published with this going in. |
Yes, as mentionned above, this will require changes in release-manager DSL. |
@@ -39,6 +39,7 @@ type Spec struct { | |||
PostInstallSteps *transpiler.StepList `yaml:"post_install"` | |||
PreUninstallSteps *transpiler.StepList `yaml:"pre_uninstall"` | |||
When string `yaml:"when"` | |||
Constraints string `yaml:"constraints"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added contraints section which is basically a when section eql expression, evaluated before transformations to save some time.
runtime.os/arch were injected into a tree beforehand, so far as a separate keys not a map, we need to add support for accessing dict elements in eql expression
cc @blakerouse as you already approved the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question, we are adding a new key "constraints", could this be handled already by the "when" key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could but it would mean we do the transformation which are not even necessary and then filter out all of the results because precondition failed. i wanted us to spare compute cycles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect usage of EQL conditions, awesome!
@blakerouse and @michalpristas Its exciting to see EQL syntax reused in other places! |
[Ingest Manager] Support for linux/arm64 (elastic#23479)
[Ingest Manager] Support for linux/arm64 (elastic#23479)
What does this PR do?
Just adds a correct arch for arm64 so arm64 beats are downloaded.
Tested on AWS arm64 server, dashboards seemed ok.
Why is it important?
support Arm 64 packages
How to test
Ideally you have an arm64 device or libvirt enabled and it's easy.
What i did is that I
DEV=true SNAPSHOT=TRUE PLATFORMS="linux/arm64" mage package
commanddata/elastic-agent-*/downloads
directoryChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.