Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Remove TCP input from fortinet fileset #23705

Closed
wants to merge 1 commit into from

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Removes TCP input from fortinet fileset. Filebeat doesn't currently
support necessary options to receive TCP syslog from Fortinet systems.

Why is it important?

Document correct behavior.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

- remove tcp from fortinet docs
- remove tcp from fortinet configs
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 26, 2021
@leehinman leehinman added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Jan 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 26, 2021
@leehinman leehinman requested a review from P1llus January 26, 2021 23:14
@andrewkroh
Copy link
Member

I think we can now replace this PR with one to update the module to use the enhancement in #23724. Can we close this one out?

@leehinman
Copy link
Contributor Author

Yep, I'll close this and open one to add framing support to fortinet. Just didn't want to forget in case we didn't get the framing stuff done.

@leehinman leehinman closed this Feb 1, 2021
@leehinman leehinman deleted the fortinet_doc_update branch May 14, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants