Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24019 to 7.x: Update dependencies for M1 support in System #24093

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Feb 17, 2021

Cherry-pick of PR #24019 to 7.x branch. Original message:

What does this PR do?

This is the result of updating go-sysinfo and gosigar and running go mod tidy. I'm still in the process of testing Metricbeat as a whole against M1, and some holes in the test tooling aren't helping, so I'm just putting in this PR now.

Why is it important?

The updates in the upstream system package are needed for M1 Mac support.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR
  • Build metricbeat for darwin/arm
  • Make sure it builds.

Related issues

* update dependencies for M1 support

* add changelog entry

* make notice

* notice

(cherry picked from commit d0d1abc)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 17, 2021
@fearful-symmetry fearful-symmetry requested a review from a team February 17, 2021 22:48
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 17, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24093 updated

  • Start Time: 2021-02-18T00:05:43.581+0000

  • Duration: 121 min 26 sec

  • Commit: 23d70c9

Test stats 🧪

Test Results
Failed 0
Passed 46577
Skipped 4981
Total 51558

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46577
Skipped 4981
Total 51558

@fearful-symmetry fearful-symmetry merged commit d600702 into elastic:7.x Feb 18, 2021
@zube zube bot removed the [zube]: Done label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants