Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24133 to 7.x: [Filebeat] Adding fixes to the TI module #24137

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Feb 19, 2021

Cherry-pick of PR #24133 to 7.x branch. Original message:

What does this PR do?

Cleaning up the TI module based on feedback after testing the BC runs.

Why is it important?

Cleaning up the TI module based on feedback after testing the BC runs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* cleaning up TI module, adding safer config options, updating docs and fixing the MISP tag copy painless script

* updating otx pipeline to remove specific null value

* fixing grok pattern in MISP to fetch hash values

(cherry picked from commit f394755)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24137 opened

  • Start Time: 2021-02-19T18:41:45.583+0000

  • Duration: 47 min 2 sec

  • Commit: 7d74ec3

Test stats 🧪

Test Results
Failed 0
Passed 13022
Skipped 2229
Total 15251

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13022
Skipped 2229
Total 15251

@P1llus P1llus merged commit 20026ba into elastic:7.x Feb 19, 2021
@zube zube bot removed the [zube]: Done label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants