-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] reuse configuration from the workers if possible #24184
Conversation
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 6 |
Passed | 46863 |
Skipped | 4975 |
Total | 51844 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/cloudwatch
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/ec2
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/rds
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/s3_daily_storage
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/s3_request
- Name:
Build&Test / x-pack/metricbeat-cloud / TestFetch – github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/sqs
@@ -11,7 +11,7 @@ if command -v kind | |||
then | |||
echo "Found Kind. Checking version.." | |||
FOUND_KIND_VERSION=$(kind --version 2>&1 >/dev/null | awk '{print $3}') | |||
if [ $FOUND_KIND_VERSION == $KIND_VERSION ] | |||
if [ "$FOUND_KIND_VERSION" == "$KIND_VERSION" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting
if command -v kubectl | ||
then | ||
echo "Found kubectl. Checking version.." | ||
FOUND_KUBECTL_VERSION=$(kubectl version --client --short 2>&1 >/dev/null | awk '{print $3}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ kubectl version --client --short
Client Version: v1.20.2
$ kubectl version --client --short 2>&1 >/dev/null | awk '{print $3}'
v1.20.2
if command -v terraform | ||
then | ||
echo "Found Terraform. Checking version.." | ||
FOUND_TERRAFORM_VERSION=$(terraform --version | awk '{print $2}' | sed s/v//) | ||
if [ $FOUND_TERRAFORM_VERSION == $TERRAFORM_VERSION ] | ||
if [ "$FOUND_TERRAFORM_VERSION" == "$TERRAFORM_VERSION" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting
ARCH_SUFFIX=arm | ||
fi | ||
|
||
if curl -sSLo - "https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${OS}_${ARCH_SUFFIX}.zip" > "${TERRAFORM_CMD}.zip" ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Reuse if possible the installed tools in the worker
Why is it important?
Reduce the environmental issues when tooling is installed on the fly.