-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Prepare Changelog for 7.12.0 #24656
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
Will remove the empty sections after the breaking changes are reviewed and before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few spelling/grammar nits
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Thanks @bmorelli25 |
* docs: Prepare Changelog for 7.12.0 (#24656) * docs: Close changelog for 7.12.0 * 23334 is not a breaking change * Fix link * Fix dangling line * More fixes * No need to add empty lines * Some cleanup * Final cleanup * Additional fix * Apply suggestions from code review Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> (cherry picked from commit 60dddef) * Remove not needed additions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* docs: Prepare Changelog for 7.12.0 (elastic#24656) * docs: Close changelog for 7.12.0 * 23334 is not a breaking change * Fix link * Fix dangling line * More fixes * No need to add empty lines * Some cleanup * Final cleanup * Additional fix * Apply suggestions from code review Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> (cherry picked from commit 60dddef) * Remove not needed additions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 672e1b8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being a little late on the review. Just some minor formatting issues.
- Zeek DNS: Ignore failures in data type conversions. And change `dns.id` JSON field to a string to match its `keyword` mapping. {pull}23424[23424] | ||
- Update `filestream` reader offset when a line is skipped. {pull}23417[23417] | ||
- Add check for empty values in azure module. {pull}24156[24156] | ||
- Change the `event.created` in Netflow events to be the time the event was created by Filebeat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a PR ref to {pull}23094[23094]
.
|
||
- Bundle synthetics dependencies with Heartbeat docker image. {pull}23274[23274] | ||
|
||
*Heartbeat* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triplicate heartbeat sections here that should be merged.
* Forward port 7.12.0 changelog to 7.x (#24684) * docs: Prepare Changelog for 7.12.0 (#24656) * docs: Close changelog for 7.12.0 * 23334 is not a breaking change * Fix link * Fix dangling line * More fixes * No need to add empty lines * Some cleanup * Final cleanup * Additional fix * Apply suggestions from code review Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> (cherry picked from commit 60dddef) * Remove not needed additions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 672e1b8) * Remove not needed additions * Remove not needed additions * Sync removals * Revert "Sync removals" This reverts commit d5eb48a. * sync Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
I guess I'm a little late to the review. Running
|
Nice investigation, @urso. The entries for #24072, which account for most of the suspicious set, are correct. We first submitted small PRs against a branch and then merged the branch as a single PR. Decided to keep each individual changelog entry because it makes it easier to see what was updated and what wasn't. |
* docs: Close changelog for 7.12.0 * 23334 is not a breaking change * Fix link * Fix dangling line * More fixes * No need to add empty lines * Some cleanup * Final cleanup * Additional fix * Apply suggestions from code review Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Andres Rodriguez <andresrc@gmail.com> Co-authored-by: Andres Rodriguez <andres.rodriguez@elastic.co> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Prepare Changelog for 7.12.0.
Merge after first BC.