-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding threads_cached,threads_created,threads_connected,threads_running to mysql module exports. #2484
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
Hi @claygorman, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
Hey @karmi, sorry about that! I have added the other email. I hope that does it? Thanks! |
@claygorman Thanks a lot for the PR. CLA looks good now. A few more things that need to be done:
This should fix the CI issue. Let me know if you need some more details. |
On the Thank you for your guidance. |
You need to run Probably you have to rebase on top of master as your branch now has a merge conflict. |
Ok I believe I resolved the conflict. Please let me know if it looks ok. Thanks |
No, it doesn't look correct since the changeset includes a bunch of other people's commits. |
Ok... I think i rebased properly this time? |
@claygorman Yeah, it looks like you fixed it :) jenkins, test it |
to mysql module exports in data.go
Updated ES templates for mysql module Ran make collect to generate updates
Updated ES templates for mysql module Ran make collect to generate updates
jenkins, test it |
jenkins, retest it |
@claygorman Merged. Thanks a lot for the contribution. It should be available in the next hours in the snapshot builds: https://beats-nightlies.s3.amazonaws.com/index.html?prefix=filebeat/ |
Thanks! |
I noticed in https://beats-nightlies.s3.amazonaws.com/index.html?prefix=metricbeat/ the last file modified date was 2016-09-07T10:06:33.000Z and it is currently 2016-09-09T16:59:44.781Z. Seems like snapshot hasn't been updated in 2 days (I assume its at ~10:00 every day)? |
It's fixed now. New snapshots are published. |
awesome you guys have been very helpful! |
See https://discuss.elastic.co/t/mysql-exports/59899 for information.