Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build directory #251

Merged
merged 4 commits into from
Sep 17, 2015
Merged

Remove build directory #251

merged 4 commits into from
Sep 17, 2015

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Sep 16, 2015

This just deletes the build/ folder from the repository. It was committed by mistake, it's contents are generated when building the packages.

Thanks to @darxriggs for reporting it here.

Remove build directory.
61c433e 
It was committed by mistake here.
tsg referenced this pull request Sep 16, 2015
Argh, different syntax on linux
cb72d3a
@darxriggs
Copy link
Contributor

I would also add it to .gitignore and to the clean target in the Makefile.
I am not sure how you "maintain" the directory creation itself as the install_cfg target does only copy files to the build directory but does not create it.

@tsg
Copy link
Contributor Author

tsg commented Sep 17, 2015

Added build/ to the .gitignore. The directory is created from beats-packer, and actually it's normally not in the repository directory but put under /build/ in a docker container. When I committed it by mistake I must have done manual testing of it.

@tsg tsg added the review label Sep 17, 2015
@ruflin
Copy link
Contributor

ruflin commented Sep 17, 2015

@tsg Looks good to me. Can you merge in again master as there is a conflict?

@tsg
Copy link
Contributor Author

tsg commented Sep 17, 2015

Merged master.

ruflin added a commit that referenced this pull request Sep 17, 2015
@ruflin
Merge pull request #251 from tsg/remove_build_dir
d76c9c2 
Remove build directory
@ruflin ruflin merged commit d76c9c2 into elastic:master Sep 17, 2015
andrewkroh added a commit that referenced this pull request Dec 2, 2015
@andrewkroh
Rename bulk_size config variable to bulk_max_size to match existing d…
44e2c63 
…ocumentation and configuration files.

Closes #251
tsg pushed a commit to tsg/beats that referenced this pull request Jan 20, 2016
@ruflin
Merge pull request elastic#251 from tsg/remove_build_dir
5070d23 
Remove build directory
tsg pushed a commit to tsg/beats that referenced this pull request Jan 20, 2016
@andrewkroh
Rename bulk_size config variable to bulk_max_size to match existing d…
2ba88bf 
…ocumentation and configuration files.

Closes elastic#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsg @darxriggs @ruflin