Add shutdown timeout #2514
Merged
Add shutdown timeout #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s.AddTimer(time.NewTimer(d)) | ||
| } | ||
|
|
||
| func (s *signalWait) Signal() { |
There was a problem hiding this comment.
It's for sending inserting a signal. E.g. having received Ctrl-C one can use Signal() to insert a signal into the waiter that triggers right now, such that Wait will not block.
e.g.
<- fb.done
if whatever {
sigWait.Signal()
}
Introduce signalWait structure to filebeat waiting for stop signal after fb.done was closed. If shutdown_timeout is configured, filebeat will either stop after timeout or after all enqueued events have been successfully published and written by registrar.
urso
force-pushed
the
enh/filebeat-to-shutdown
branch
from
ed4900b to
28e3906
Compare
|
LGTM |
| @@ -106,6 +125,12 @@ func (fb *Filebeat) Run(b *beat.Beat) error { | |||
| // Blocks progressing. As soon as channel is closed, all defer statements come into play | |||
| <-fb.done | |||
|
|
|||
| if fb.config.ShutdownTimeout > 0 { | |||
| // Wait for either timeout or all events having been ACKed by outputs. | |||
There was a problem hiding this comment.
We should add here a log message that shutdown will wait for time X to shutdown or success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce signalWait structure to filebeat waiting for stop signal after
fb.done was closed. If shutdown_timeout is configured, filebeat will either
stop after timeout or after all enqueued events have been successfully
published and written by registrar.
I hope the signalWait idea can be reused for implementing run-once mode as well.