Add structured logging to logs input #25299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The logging of the logs input is updated to make use of structured
logging. Each logs input instance will create an unique ID, that will be
logged as "input_id".
The input and harvester will also add file state information like:
source, state_id, finished, os_id. The os_id holds the inode, and
state_id is the ID that is used internally by filebeat to track the
file.
Why is it important?
By filtering the logs for one or the other ID, one can track all
logs at a different level. Filtering by "state_id" allows us to monitor
all logs and state changes for a given file, even if the file is
renamed, closed and reopened.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Run filebeat with the logs input and debug logs enabled.
File state updates after a scan or harvester logs should log contextual information like the inode, state_id, harvester_id, input_id.