Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] fortinet.firewall.addr is not always an IP address #25608

Merged
merged 3 commits into from
May 10, 2021
Merged

[Filebeat] fortinet.firewall.addr is not always an IP address #25608

merged 3 commits into from
May 10, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 7, 2021 •
edited
Loading

What does this PR do?

Accounts for when fortinet.firewall.addr is not always an IP address. Adds fix provided in #25585.

Why is it important?

Causes ingest errors as a fortinet.firewall.addr is set to type IP

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd beats/x-pack/filebeat
TESTING_FILEBEAT_MODULES=fortinet TESTING_FILEBEAT_FILESETS=firewall mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2021
@legoguy1000 legoguy1000 force-pushed the 25585-fortinet-addr-field branch from 47591dc to 8159597 Compare May 7, 2021 00:19
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 7, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: run tests

  • Start Time: 2021-05-10T11:41:23.502+0000

  • Duration: 113 min 51 sec

  • Commit: 71a38f2

Test stats 🧪

Test Results
Failed 0
Passed 7010
Skipped 1193
Total 8203

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7010
Skipped 1193
Total 8203

@legoguy1000
Copy link
Contributor Author

Some reason the generated data is updating. Still need to take a look at it.

@legoguy1000 legoguy1000 changed the title 25585: fortinet.firewall.addr is not always an IP address [Filebeat] fortinet.firewall.addr is not always an IP address May 7, 2021
@legoguy1000 legoguy1000 marked this pull request as ready for review May 9, 2021 13:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2021
@P1llus P1llus self-assigned this May 10, 2021
@P1llus
Copy link
Member

P1llus commented May 10, 2021

run tests

@legoguy1000 legoguy1000 force-pushed the 25585-fortinet-addr-field branch from bcfb7a5 to 71a38f2 Compare May 10, 2021 11:34
@P1llus
Copy link
Member

P1llus commented May 10, 2021

run tests

P1llus
P1llus approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus P1llus merged commit 2fc3a4d into elastic:master May 10, 2021
@P1llus P1llus added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels May 10, 2021
@legoguy1000 legoguy1000 deleted the 25585-fortinet-addr-field branch May 10, 2021 18:16
mergify bot pushed a commit that referenced this pull request May 10, 2021
@legoguy1000
[Filebeat] fortinet.firewall.addr is not always an IP address (#25608)
78f9bb3 
* 25585: `fortinet.firewall.addr` is not always an IP address

* update sample logs

* fixed pipeline

(cherry picked from commit 2fc3a4d)
@mergify mergify bot mentioned this pull request May 10, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 10, 2021
@legoguy1000
[Filebeat] fortinet.firewall.addr is not always an IP address (#25608)
52e9d36 
* 25585: `fortinet.firewall.addr` is not always an IP address

* update sample logs

* fixed pipeline

(cherry picked from commit 2fc3a4d)
@mergify mergify bot mentioned this pull request May 10, 2021
Merged
P1llus pushed a commit that referenced this pull request May 11, 2021
@mergify @legoguy1000
[Filebeat] fortinet.firewall.addr is not always an IP address (#25608…
0bf49ee 
…) (#25650)

* 25585: `fortinet.firewall.addr` is not always an IP address

* update sample logs

* fixed pipeline

(cherry picked from commit 2fc3a4d)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
cachedout pushed a commit that referenced this pull request May 18, 2021
@legoguy1000
[Filebeat] fortinet.firewall.addr is not always an IP address (#25608)
8638fe1 
* 25585: `fortinet.firewall.addr` is not always an IP address

* update sample logs

* fixed pipeline

(cherry picked from commit 2fc3a4d)
P1llus pushed a commit that referenced this pull request Jun 25, 2021
@mergify @legoguy1000 @jsoriano
[Filebeat] fortinet.firewall.addr is not always an IP address (#25608…
1fd6b29 
…) (#25649)

* 25585: `fortinet.firewall.addr` is not always an IP address

* update sample logs

* fixed pipeline

(cherry picked from commit 2fc3a4d)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

@P1llus P1llus

Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat][Fortinet Module] fortinet.firewall.addr is not always an IP address, causing ingest errors
3 participants
@legoguy1000 @elasticmachine @P1llus