Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Fix checkpoint.action_reason when its a string, not a Long #25609

Merged
merged 1 commit into from
May 10, 2021
Merged

[Filebeat] Fix checkpoint.action_reason when its a string, not a Long #25609

merged 1 commit into from
May 10, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 7, 2021 •
edited
Loading

What does this PR do?

Renames checkpoint.action_reason to checkpoint.action_reason_msg when its a string, not a Long

Why is it important?

Causes ingest errors due to mismatch mapping

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd beats/x-pack/filebeat
TESTING_FILEBEAT_MODULES=checkpoint TESTING_FILEBEAT_FILESETS=firewall mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2021
@legoguy1000 legoguy1000 force-pushed the 25575-checkpoint-action_reason branch from c6d54e7 to 5b3cb61 Compare May 7, 2021 00:50
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 7, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: run tests

  • Start Time: 2021-05-07T10:48:30.606+0000

  • Duration: 108 min 22 sec

  • Commit: 243ba63

Test stats 🧪

Test Results
Failed 0
Passed 13710
Skipped 2285
Total 15995

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13710
Skipped 2285
Total 15995

@legoguy1000 legoguy1000 force-pushed the 25575-checkpoint-action_reason branch from 5b3cb61 to 243ba63 Compare May 7, 2021 01:10
@legoguy1000 legoguy1000 marked this pull request as ready for review May 7, 2021 01:10
@P1llus
Copy link
Member

P1llus commented May 7, 2021

run tests

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2021
@P1llus P1llus self-assigned this May 10, 2021
@P1llus P1llus merged commit f432b92 into elastic:master May 10, 2021
@legoguy1000 legoguy1000 deleted the 25575-checkpoint-action_reason branch May 10, 2021 11:32
@P1llus P1llus added backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify labels May 10, 2021
mergify bot pushed a commit that referenced this pull request May 10, 2021
@legoguy1000
#25575: Fix checkpoint.action_reason when its a string, not a Long (#…
f2220f9 
…25609)

(cherry picked from commit f432b92)

# Conflicts:
#	x-pack/filebeat/module/checkpoint/fields.go
@mergify mergify bot mentioned this pull request May 10, 2021
Merged
@P1llus P1llus added the backport-v7.14.0 Automated backport with mergify label May 10, 2021
mergify bot pushed a commit that referenced this pull request May 10, 2021
@legoguy1000
#25575: Fix checkpoint.action_reason when its a string, not a Long (#…
e1ed544 
…25609)

(cherry picked from commit f432b92)

# Conflicts:
#	x-pack/filebeat/module/checkpoint/fields.go
@mergify mergify bot mentioned this pull request May 10, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 10, 2021
@legoguy1000
#25575: Fix checkpoint.action_reason when its a string, not a Long (#…
4874901 
…25609)

(cherry picked from commit f432b92)
@mergify mergify bot mentioned this pull request May 10, 2021
Merged
P1llus pushed a commit that referenced this pull request May 10, 2021
@mergify @legoguy1000
#25575: Fix checkpoint.action_reason when its a string, not a Long (#…
1535303 
…25609) (#25635)

(cherry picked from commit f432b92)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
P1llus added a commit that referenced this pull request May 10, 2021
@mergify @legoguy1000 @P1llus
[7.13](backport #25609) [Filebeat] Fix checkpoint.action_reason whe…
fd9564b 
…n its a string, not a Long (#25633)

* #25575: Fix `checkpoint.action_reason` when its a string, not a Long (#25609)

(cherry picked from commit f432b92)

# Conflicts:
#	x-pack/filebeat/module/checkpoint/fields.go

* updating fields.go

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
P1llus added a commit that referenced this pull request May 10, 2021
@mergify @legoguy1000 @P1llus
[7.12](backport #25609) [Filebeat] Fix checkpoint.action_reason whe…
afee026 
…n its a string, not a Long (#25634)

* #25575: Fix `checkpoint.action_reason` when its a string, not a Long (#25609)

(cherry picked from commit f432b92)

# Conflicts:
#	x-pack/filebeat/module/checkpoint/fields.go

* updating fields.go

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @legoguy1000 @P1llus
[7.12](backport elastic#25609) [Filebeat] Fix `checkpoint.action_reas…
4b498a2 
…on` when its a string, not a Long (elastic#25634)

* elastic#25575: Fix `checkpoint.action_reason` when its a string, not a Long (elastic#25609)

(cherry picked from commit 8b53162)

# Conflicts:
#	x-pack/filebeat/module/checkpoint/fields.go

* updating fields.go

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

@P1llus P1llus

Labels
backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filebeat: CheckPoint module fails to parse action_reason
3 participants
@legoguy1000 @elasticmachine @P1llus