Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 32 bits version of Elastic Agent. #25708

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Remove 32 bits version of Elastic Agent. #25708

merged 2 commits into from
Jun 8, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented May 13, 2021

What does this PR do?

We want to deliver ASLR version of our binaries and this is only supported on 64 bits system.

Why is it important?

Address space layout randomization (ASLR) is a computer security technique involved in preventing exploitation of memory corruption vulnerabilities.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

ph added 2 commits May 13, 2021 14:41
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 13, 2021
@ph ph added the Team:Elastic-Agent Label for the Agent team label May 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 13, 2021
@ph ph added needs_team Indicates that the issue/PR needs a Team:* label v7.13.0 labels May 13, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 13, 2021
@botelastic
Copy link

botelastic bot commented May 13, 2021

This pull request doesn't have a Team:<team> label.

@ph ph added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels May 13, 2021
@ph
Copy link
Contributor Author

ph commented May 13, 2021

/Package

@ph ph removed the backport-v7.13.0 Automated backport with mergify label May 13, 2021
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25708 opened

  • Start Time: 2021-05-13T18:48:08.690+0000

  • Duration: 100 min 43 sec

  • Commit: 26edfed

Test stats 🧪

Test Results
Failed 0
Passed 6892
Skipped 16
Total 6908

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 2

Expand to view the steps failures

x-pack/elastic-agent-packaging-arm-arm - mage package
  • Took 21 min 49 sec . View more details on here
  • Description: mage package
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

Log output

Expand to view the last 100 lines of log output

[2021-05-13T20:26:22.354Z]  API version:       1.41
[2021-05-13T20:26:22.354Z]  Go version:        go1.13.15
[2021-05-13T20:26:22.354Z]  Git commit:        48d30b5
[2021-05-13T20:26:22.354Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-05-13T20:26:22.354Z]  OS/Arch:           linux/amd64
[2021-05-13T20:26:22.354Z]  Context:           default
[2021-05-13T20:26:22.354Z]  Experimental:      true
[2021-05-13T20:26:22.354Z] 
[2021-05-13T20:26:22.354Z] Server: Docker Engine - Community
[2021-05-13T20:26:22.354Z]  Engine:
[2021-05-13T20:26:22.354Z]   Version:          20.10.3
[2021-05-13T20:26:22.354Z]   API version:      1.41 (minimum version 1.12)
[2021-05-13T20:26:22.354Z]   Go version:       go1.13.15
[2021-05-13T20:26:22.354Z]   Git commit:       46229ca
[2021-05-13T20:26:22.354Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-05-13T20:26:22.354Z]   OS/Arch:          linux/amd64
[2021-05-13T20:26:22.354Z]   Experimental:     false
[2021-05-13T20:26:22.354Z]  containerd:
[2021-05-13T20:26:22.354Z]   Version:          1.4.4
[2021-05-13T20:26:22.354Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-05-13T20:26:22.354Z]  runc:
[2021-05-13T20:26:22.354Z]   Version:          1.0.0-rc93
[2021-05-13T20:26:22.354Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-05-13T20:26:22.354Z]  docker-init:
[2021-05-13T20:26:22.354Z]   Version:          0.19.0
[2021-05-13T20:26:22.354Z]   GitCommit:        de40ad0
[2021-05-13T20:26:22.354Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-05-13T20:26:22.354Z] Unable to find image 'alpine:3.4' locally
[2021-05-13T20:26:22.924Z] 3.4: Pulling from library/alpine
[2021-05-13T20:26:23.185Z] c1e54eec4b57: Pulling fs layer
[2021-05-13T20:26:23.445Z] c1e54eec4b57: Verifying Checksum
[2021-05-13T20:26:23.707Z] c1e54eec4b57: Pull complete
[2021-05-13T20:26:23.707Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2021-05-13T20:26:23.707Z] Status: Downloaded newer image for alpine:3.4
[2021-05-13T20:26:25.619Z] Change permissions with write access of all files inside the specific folder
[2021-05-13T20:26:26.591Z] Running in /var/lib/jenkins/workspace/PR-25708-1-164946f9-c365-4a7c-b066-9ff3f30f2989/src/github.com/elastic/beats/build
[2021-05-13T20:26:26.914Z] + rm -rf ve
[2021-05-13T20:26:26.914Z] + find . -type d -name vendor -exec rm -r {} ;
[2021-05-13T20:26:27.279Z] + python .ci/scripts/pre_archive_test.py
[2021-05-13T20:26:37.274Z] Copy ./x-pack/metricbeat/build into build/x-pack/metricbeat/build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/metricbeat/build/golang-crossbuild into build/x-pack/metricbeat/build/golang-crossbuild
[2021-05-13T20:26:37.274Z] Copy ./x-pack/heartbeat/build into build/x-pack/heartbeat/build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/heartbeat/build/golang-crossbuild into build/x-pack/heartbeat/build/golang-crossbuild
[2021-05-13T20:26:37.274Z] Copy ./x-pack/elastic-agent/build into build/x-pack/elastic-agent/build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/elastic-agent/build/golang-crossbuild into build/x-pack/elastic-agent/build/golang-crossbuild
[2021-05-13T20:26:37.274Z] Copy ./x-pack/elastic-agent/build/package/elastic-agent-ubi8/elastic-agent-linux-amd64.docker/docker-build into build/x-pack/elastic-agent/build/package/elastic-agent-ubi8/elastic-agent-linux-amd64.docker/docker-build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/elastic-agent/build/package/elastic-agent/elastic-agent-linux-amd64.docker/docker-build into build/x-pack/elastic-agent/build/package/elastic-agent/elastic-agent-linux-amd64.docker/docker-build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/filebeat/build into build/x-pack/filebeat/build
[2021-05-13T20:26:37.274Z] Copy ./x-pack/filebeat/build/golang-crossbuild into build/x-pack/filebeat/build/golang-crossbuild
[2021-05-13T20:26:37.300Z] Running in /var/lib/jenkins/workspace/PR-25708-1-164946f9-c365-4a7c-b066-9ff3f30f2989/src/github.com/elastic/beats/build
[2021-05-13T20:26:37.340Z] Recording test results
[2021-05-13T20:26:38.423Z] None of the test reports contained any result
[2021-05-13T20:26:38.433Z] [Checks API] No suitable checks publisher found.
[2021-05-13T20:26:38.877Z] + go clean -modcache
[2021-05-13T20:26:42.513Z] Cleaning up /var/lib/jenkins/workspace/PR-25708-1-164946f9-c365-4a7c-b066-9ff3f30f2989
[2021-05-13T20:26:42.513Z] Client: Docker Engine - Community
[2021-05-13T20:26:42.513Z]  Version:           20.10.3
[2021-05-13T20:26:42.513Z]  API version:       1.41
[2021-05-13T20:26:42.513Z]  Go version:        go1.13.15
[2021-05-13T20:26:42.513Z]  Git commit:        48d30b5
[2021-05-13T20:26:42.513Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-05-13T20:26:42.513Z]  OS/Arch:           linux/amd64
[2021-05-13T20:26:42.513Z]  Context:           default
[2021-05-13T20:26:42.513Z]  Experimental:      true
[2021-05-13T20:26:42.513Z] 
[2021-05-13T20:26:42.513Z] Server: Docker Engine - Community
[2021-05-13T20:26:42.513Z]  Engine:
[2021-05-13T20:26:42.513Z]   Version:          20.10.3
[2021-05-13T20:26:42.513Z]   API version:      1.41 (minimum version 1.12)
[2021-05-13T20:26:42.513Z]   Go version:       go1.13.15
[2021-05-13T20:26:42.513Z]   Git commit:       46229ca
[2021-05-13T20:26:42.513Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-05-13T20:26:42.513Z]   OS/Arch:          linux/amd64
[2021-05-13T20:26:42.513Z]   Experimental:     false
[2021-05-13T20:26:42.513Z]  containerd:
[2021-05-13T20:26:42.513Z]   Version:          1.4.4
[2021-05-13T20:26:42.513Z]   GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
[2021-05-13T20:26:42.514Z]  runc:
[2021-05-13T20:26:42.514Z]   Version:          1.0.0-rc93
[2021-05-13T20:26:42.514Z]   GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
[2021-05-13T20:26:42.514Z]  docker-init:
[2021-05-13T20:26:42.514Z]   Version:          0.19.0
[2021-05-13T20:26:42.514Z]   GitCommit:        de40ad0
[2021-05-13T20:26:42.514Z] Change ownership of all files inside the specific folder from root/root to current user/group
[2021-05-13T20:27:38.774Z] Change permissions with write access of all files inside the specific folder
[2021-05-13T20:27:38.816Z] Running in /var/lib/jenkins/workspace/PR-25708-1-164946f9-c365-4a7c-b066-9ff3f30f2989
[2021-05-13T20:27:44.866Z] + gsutil --version
[2021-05-13T20:27:46.300Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-05-13T20:27:46.640Z] + gcloud auth activate-service-account --key-file ****
[2021-05-13T20:27:47.214Z] Activated service account credentials for: [beats-ci-gcs-plugin@elastic-ci-prod.iam.gserviceaccount.com]
[2021-05-13T20:27:47.581Z] + gsutil -m -q cp -a public-read eC1wYWNrL2VsYXN0aWMtYWdlbnQtcGFja2FnaW5nLWxpbnV4MjZlZGZlZGFkZGMyMzQ5NDZjNTI5NWEyYjljNmEwMWMxZTMyNjdlOQ gs://beats-ci-temp/ci/cache/
[2021-05-13T20:27:49.747Z] Stage "Packaging-Pipeline" skipped due to earlier failure(s)
[2021-05-13T20:27:49.861Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-25708/src/github.com/elastic/beats
[2021-05-13T20:27:50.522Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-25708
[2021-05-13T20:27:50.618Z] [INFO] getVaultSecret: Getting secrets
[2021-05-13T20:27:50.664Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-05-13T20:27:51.584Z] + chmod 755 generate-build-data.sh
[2021-05-13T20:27:51.584Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25708/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25708/runs/1 FAILURE 5982621
[2021-05-13T20:27:51.584Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25708/runs/1/steps/?limit=10000 -o steps-info.json
[2021-05-13T20:27:52.928Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-25708/runs/1/tests/?status=FAILED -o tests-errors.json

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6892
Skipped 16
Total 6908

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ph ph merged commit f71a0d2 into elastic:master Jun 8, 2021
@ph ph deleted the 32bits branch June 8, 2021 18:29
mergify bot pushed a commit that referenced this pull request Jun 8, 2021
ph added a commit that referenced this pull request Jun 16, 2021
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
* master: (26 commits)
  Report total and free CPU for vSphere virtual machines (elastic#26167)
  [filebeat] Add preserve_original_event option to o365audit input (elastic#26273)
  Change xml processor names in script processor to match convention (elastic#26263)
  [Oracle] Fixing default values for paths in config template (elastic#26276)
  Add more ECS fields to logs (elastic#25998)
  [Heartbeat] Fix broken invocation of synth package (elastic#26228)
  rename sqs file name (elastic#26227)
  Populate the agent action result if there is no matching action handlers (elastic#26152)
  Add ISO8601 as supported timestamp type (elastic#25564)
  Move Filebeat azure module to GA (elastic#26168)
  Filebeat azure module pipeline fixes and changes (elastic#26148)
  libbeat: monitor version (elastic#26214)
  Add new parser to filestream input: container (elastic#26115)
  [Metricbeat] Add state_statefulset replicas.ready (elastic#26088)
  Disable test processors system test for windows 10 (elastic#26216)
  Fix startup with failing configuration (elastic#26126)
  Remove 32 bits version of Elastic Agent. (elastic#25708)
  Chane fleetmode detection to ony use management.enabled (elastic#26180)
  Make `filestream` input GA (elastic#26127)
  libbeat/idxmgmt/ilm: fix alias creation (elastic#26146)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants