Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kinesis metricset #25989

Merged
merged 7 commits into from
Jun 29, 2021
Merged

Add kinesis metricset #25989

merged 7 commits into from
Jun 29, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 28, 2021 •
edited
Loading

What does this PR do?

This PR is to add a new metricset in aws module to collect Amazon Kinesis metrics from CloudWatch.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Enable aws module: ./metricbeat module enable aws
  2. Change aws.yml to:
- module: aws
  period: 1m
  credential_profile_name: elastic-beats
  metricsets:
    - kinesis
  1. Start Metricbeat: ./metricbeat -e

Related issues

Screenshots

TBD

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 28, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this May 28, 2021
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. needs_integration_sync Changes in this PR need synced to elastic/integrations. Team:Integrations Label for the Integrations team labels May 28, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 28, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 28, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25989 updated

  • Start Time: 2021-06-29T18:42:06.685+0000

  • Duration: 104 min 40 sec

  • Commit: e926664

Test stats 🧪

Test Results
Failed 0
Passed 8680
Skipped 2574
Total 11254

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8680
Skipped 2574
Total 11254

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review June 28, 2021 22:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng kaiyan-sheng requested a review from sayden June 29, 2021 00:47
sayden
sayden approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity that we cannot manipulate field names but we are as good as we can be. Good work!

@jsoriano
Copy link
Member

It's a pity that we cannot manipulate field names but we are as good as we can be.

@sayden what do you mean? If wanted, it is possible to use processors to rename fields, as is actually done in other aws modules. We can decide to leave them as they are if we want to keep the original naming/structure, but we have the choice to manipulate fields and their names 🙂

We could also consider adding some way of mapping to the cloudwatch metricset as other metricsets have, but that is a different story.

@kaiyan-sheng
Copy link
Contributor Author

Thanks @sayden and @jsoriano! Yeah we can manipulate the names but I want to keep the names from AWS Cloudwatch as much as I can and that's why they look so weird...

@kaiyan-sheng kaiyan-sheng merged commit ba4d7c2 into elastic:master Jun 29, 2021
@kaiyan-sheng kaiyan-sheng deleted the kinesis_metricset branch June 29, 2021 22:05
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jun 29, 2021
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.14.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 29, 2021
kaiyan-sheng added a commit that referenced this pull request Jun 30, 2021
@kaiyan-sheng
Add kinesis metricset (#25989) (#26590)
b10ba67 
(cherry picked from commit ba4d7c2)
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 30, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
218ee9a 
* master: (25 commits)
  fix: Force PLATFORMS environment variable when we build Elastic Agent dependencies on arm64 (elastic#26415)
  macos for metricbeat to run in the extended meta-stage (elastic#26573)
  Packaging: add arm7 platform in the main pipeline (elastic#26575)
  [Heartbeat] Skip flakey timer queue test (elastic#26592)
  Update to "read_pipeline" permission (elastic#26465) (elastic#26580)
  API keys do not reflect the need for read_pipeline (elastic#26466) (elastic#26582)
  Add Fleet agent.id to Agent monitoring data (elastic#26548)
  Add kinesis metricset (elastic#25989)
  Refactor of system/memory metricset (elastic#26334)
  Introduce httpcommon package in libbeat (add support for Proxy) (elastic#25219)
  [Filebeat] change multiline configuration in awss3 input to parsers (elastic#25873)
  docs: Hint for the error "Error extracting container id" (elastic#25824)
  [Docs] Fixed metricbeat redis exported field CPU descriptions (elastic#25846) (elastic#26496)
  Update urllib to 1.26.5. (elastic#26380)
  Update golang.org/x/crypto (elastic#26448)
  [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816)
  Move parsers outside of filestream input so others can use them as well (elastic#26541)
  [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508)
  [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620)
  Logging code cleanup related to Nomad auto-discovery (elastic#26498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
needs_integration_sync Changes in this PR need synced to elastic/integrations. Team:Integrations Label for the Integrations team v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] AWS Kinesis metricset
4 participants
@kaiyan-sheng @elasticmachine @jsoriano @sayden