Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #26117 to 7.x: Migrate sqs metricset to use cloudwatch input as light weight module #26139

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 3, 2021

Cherry-pick of PR #26117 to 7.x branch. Original message:

What does this PR do?

This PR is to migrate sqs metricset to use cloudwatch input as light weight module. Two main parts in this PR:

In the original sqs metricset, we are also making SQS ListQueues API call to get metadata for each SQS instance. This is added as a part of cloudwatch metricset now.
You can see under sqs metricset, there is only a manifest.yml file which defines cloudwatch as the input.

We need to keep backward compatibility with metric names so the dashboard can still be used.
You can see rename processor is used in manifest.yml file under rds metricset to make sure with this PR we are not introducing breaking changes. Also please check the updated data.json file in sqs metricset to see the renaming is effective.

Why is it important?

With this change, we no longer need to maintain the common code in both sqs metricset and cloudwatch metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 3, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 3, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26139 opened

  • Start Time: 2021-06-03T20:09:03.333+0000

  • Duration: 110 min 47 sec

  • Commit: a53c729

Test stats 🧪

Test Results
Failed 0
Passed 8810
Skipped 2395
Total 11205

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8810
Skipped 2395
Total 11205

@kaiyan-sheng kaiyan-sheng merged commit 0d60f49 into elastic:7.x Jun 3, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_26117_7.x branch June 3, 2021 22:20
@zube zube bot removed the [zube]: Done label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants