Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependent package to avoid downloading a suspicious file #26406

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Update dependent package to avoid downloading a suspicious file #26406

merged 2 commits into from
Jul 1, 2021

Conversation

kemokemo
Copy link
Contributor

What does this PR do?

Update dependent package h2non/filetype with following command.

go get -u github.com/h2non/filetype
go mod tidy

Why is it important?

The revision of h2non/filetype referenced by the elastic/beats contains a suspicious file, 'sample.dex', to prevent it from being downloaded to the developer's PC.
Please check Issue #97 of h2non/filetype for details on sample.dex, which has been removed from the current h2non/filetype tag v1.1.1.

Checklist

I think that the changes do not correspond to the following checks.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 22, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 22, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: blakerouse commented: /test

  • Start Time: 2021-07-01T14:23:04.437+0000

  • Duration: 75 min 47 sec

  • Commit: d42035f

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@jsoriano
Copy link
Member

/test

@jsoriano jsoriano added backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team labels Jun 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2021
@jsoriano
Copy link
Member

/test

4 similar comments
@jsoriano
Copy link
Member

/test

@jsoriano
Copy link
Member

/test

@ph
Copy link
Contributor

ph commented Jun 30, 2021

/test

@blakerouse
Copy link
Contributor

/test

@blakerouse blakerouse added the backport-v7.15.0 Automated backport with mergify label Jul 1, 2021
blakerouse
blakerouse approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Verified the version in the repo and that it removes that file.

@blakerouse blakerouse merged commit 127e3c6 into elastic:master Jul 1, 2021
mergify bot pushed a commit that referenced this pull request Jul 1, 2021
@kemokemo
Update dependent package to avoid downloading a suspicious file (#26406)
7f147b5 
* update to avoid downloading a suspicious file

* Update notice

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit 127e3c6)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Jul 1, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jul 1, 2021
@kemokemo
Update dependent package to avoid downloading a suspicious file (#26406)
f77d901 
* update to avoid downloading a suspicious file

* Update notice

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit 127e3c6)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Jul 1, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Jul 5, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/retry-if-…
a26267c 
…stage-failed-within-same-build

* upstream/master: (36 commits)
  Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704)
  Packaging: linux/armv7 is not supported (elastic#26706)
  Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614)
  Make network_direction, registered_domain and convert processors compatible with ES older than 7.13.0 (elastic#26676)
  Disable armv7 packaging (elastic#26679)
  [Heartbeat] use --params flag for synthetics (elastic#26674)
  Update dependent package to avoid downloading a suspicious file (elastic#26406)
  [mergify] set title and allow bp in any direction (elastic#26648)
  Fix memory leak in SQL helper when database is not available (elastic#26607)
  [CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)
  [mergify] automate PRs that change the backport rules (elastic#26641)
  [Metricbeat] Add Airflow module in xpack (elastic#26220)
  chore: add-backport-next (elastic#26620)
  [metricbeat] Add state_job metricset (elastic#26479)
  CI: jenkins labels are less time consuming now (elastic#26613)
  [MetricBeat] [AWS] Fix aws metric tags with resourcegroupstaggingapi paginator (elastic#26385) (elastic#26443)
  Move openmetrics module to oss (elastic#26561)
  Skip flaky test TestFilestreamMetadataUpdatedOnRename (elastic#26609)
  [filebeat][fortinet] Use default add_locale for fortinet.firewall (elastic#26524)
  Enroll proxy settings (elastic#26514)
  ...
blakerouse added a commit that referenced this pull request Jul 28, 2021
@mergify @kemokemo @blakerouse
[7.x](backport #26406) Update dependent package to avoid downloading …
e4812ec 
…a suspicious file (#26672)

* Update dependent package to avoid downloading a suspicious file (#26406)

* update to avoid downloading a suspicious file

* Update notice

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit 127e3c6)

# Conflicts:
#	go.sum

* Fix go.sum

Co-authored-by: kemokemo <t2wonderland@gmail.com>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
blakerouse added a commit that referenced this pull request Jul 28, 2021
@mergify @kemokemo @blakerouse
[7.14](backport #26406) Update dependent package to avoid downloading…
ba5afc4 
… a suspicious file (#26673)

* Update dependent package to avoid downloading a suspicious file (#26406)

* update to avoid downloading a suspicious file

* Update notice

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
(cherry picked from commit 127e3c6)

# Conflicts:
#	go.sum

* Fix go.sum

Co-authored-by: kemokemo <t2wonderland@gmail.com>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kemokemo @elasticmachine @jsoriano @ph @blakerouse