Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indenting correction for module configuration example #26604

Merged
merged 15 commits into from
Aug 23, 2021

Conversation

robin13
Copy link
Contributor

@robin13 robin13 commented Jun 30, 2021

What does this PR do?

Fix YAML indenting for module configuration example

Why is it important?

The example given was invalid

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

@robin13 robin13 added the docs label Jun 30, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-23T13:15:09.229+0000

  • Duration: 26 min 47 sec

  • Commit: 88883d4

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@kaiyan-sheng kaiyan-sheng requested a review from narph July 27, 2021 22:58
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Jul 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2021
@narph
Copy link
Contributor

narph commented Jul 28, 2021

hi @robin13 , nice catch , we first update https://github.com/elastic/beats/blob/master/x-pack/filebeat/module/azure/_meta/docs.asciidoc then run mage update which will regenerate the azure.asciidoc file. Mind going on the same route? This is why the build is failing as well.

@robin13
Copy link
Contributor Author

robin13 commented Aug 11, 2021

Hi @narph I don't have the whole build environment for beats set up, and it's a bit daunting for me to do this just for a typo fix...
I have corrected the changes to the correct file now, so perhaps you could do the mage update? :)

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b indenting-correction upstream/indenting-correction
git merge upstream/master
git push upstream indenting-correction

Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narph narph merged commit abf329b into elastic:master Aug 23, 2021
@narph narph added the v7.16.0 label Aug 24, 2021
narph pushed a commit to narph/beats that referenced this pull request Aug 24, 2021
* Removed outdated documentation

* Typo fix

* Corrected indenting for module configuration example

* Made changes in the _meta directory

* mage update

* changelog

Co-authored-by: narph <mariana@elastic.co>
(cherry picked from commit abf329b)
narph added a commit that referenced this pull request Aug 24, 2021
* Removed outdated documentation

* Typo fix

* Corrected indenting for module configuration example

* Made changes in the _meta directory

* mage update

* changelog

Co-authored-by: narph <mariana@elastic.co>
(cherry picked from commit abf329b)

Co-authored-by: Robin Clarke <robin.clarke@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
* Removed outdated documentation

* Typo fix

* Corrected indenting for module configuration example

* Made changes in the _meta directory

* mage update

* changelog

Co-authored-by: narph <mariana@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Integrations Label for the Integrations team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants