[Metricbeat] gcp: refactor service based metric filter creation #26973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`metricsRequester.getFilterForMetric` was using a regexp logic to extract the service name from the metric name. The service name is used to adapt the metric filter creation based on the service the metric belongs to, as different services require different filters and some are not supported. With the changes required to supporting GKE, that has a different metric prefix than other Google Cloud metrics, the logic was broken, creating a filter that was always returning an empty metric set. This commit change the logic to rely on `metricsConfig.ServiceName` instead, removing the inference on the metric name.
endorama
added
enhancement
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
endorama
changed the title
kaiyan-sheng
approved these changes
Jul 20, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
(cherry picked from commit e1185e4)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
metricsRequester.getFilterForMetricwas using a regexp logic toextract the service name from the metric name.
The service name is used to adapt the metric filter creation based on
the service the metric belongs to, as different services require
different filters and some are not supported.
With the changes required to supporting GKE, that has a different metric
prefix than other Google Cloud metrics, the logic was broken, creating a
filter that was always returning an empty metric set.
This commit change the logic to rely on
metricsConfig.ServiceNameinstead, removing the inference on the metric name.
Why is it important?
The implemented Regexp inference on the metric name does not work when the metric prefix is not in the form
<servicename>.googleapis.com. This prevent adding metricsets not related to Google Cloud metrics.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs