Kafka output drop invalid messages #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
commented
Oct 10, 2016
urso
commented
- Fix too big messages not being dropped, but forcing continuous resends
- If publishing subset of batches fails, only attempt to resend failed events instead of complete batch
urso
added
review
needs_backport
urso
force-pushed
the
fix/kafka-resending-should-be-dropped-events
branch
from
58d0730
to
205ecea
Compare
|
LGTM |
- Fix too big messages not being dropped, but forcing continuous resends - If publishing subset of batches fails, only attempt to resend failed - events instead of complete batch
urso
force-pushed
the
fix/kafka-resending-should-be-dropped-events
branch
from
205ecea
to
4652ada
Compare
ruflin
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.