Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] gcp: add gke metricset documentation #27613

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Aug 26, 2021

What does this PR do?

Provide documentation for GKE metricset.

Why is it important?

Metricset documentation was not present in #26824.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug labels Aug 26, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2021
@endorama endorama requested a review from sayden August 26, 2021 15:20
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-01T14:24:57.715+0000

  • Duration: 103 min 16 sec

  • Commit: 1b485b4

Test stats 🧪

Test Results
Failed 0
Passed 9507
Skipped 2521
Total 12028

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9507
Skipped 2521
Total 12028

@@ -0,0 +1,31 @@
`gke` metricset is designed for collecting metrics from Google Kubernetes
Engine. GKE is the industry's first fully managed Kubernetes service that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GKE is the industry's... I'm being picky here but I'd rather talk about Beat's product than talk about Google's product. What is GKE and why is (or not) awesome should be explained (and sold) in GCP GKE's homepage. All in all, this is the "homepage" of Metricbeat GKE metricset for GCP module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I added it because I found the explanation for the monitored service in other metricsets and I copy/pasted from the GKE official page. I'll replace it with a link to the service home page.

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment but it's good enough already

@endorama endorama changed the title [Metricbeat] gcp: gke metricset documentation [Metricbeat] gcp: add gke metricset documentation Sep 2, 2021
@endorama endorama merged commit 07174bd into elastic:master Sep 2, 2021
@endorama endorama deleted the gcp/gke/fix-service branch September 2, 2021 09:58
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
endorama added a commit that referenced this pull request Sep 2, 2021
…ion (#27703)

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
endorama added a commit that referenced this pull request Sep 2, 2021
…tion (#27704)

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants