Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[httpjson] Add new join and sprintf functions #27735

Merged
merged 1 commit into from
Sep 3, 2021
Merged

[httpjson] Add new join and sprintf functions #27735

merged 1 commit into from
Sep 3, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 3, 2021 •
edited
Loading

What does this PR do?

  • Adds join and sprintf functions.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from P1llus September 3, 2021 09:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 3, 2021
P1llus
P1llus approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code looks good to me, and tests are passing. If anyone wants to take a extra look that is also fine by me.

Great work! :)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-03T11:06:47.656+0000

  • Duration: 104 min 4 sec

  • Commit: 869a8ec

Test stats 🧪

Test Results
Failed 0
Passed 8178
Skipped 1201
Total 9379

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8178
Skipped 1201
Total 9379

@marc-gr marc-gr changed the title [httpjson] Add request data to read context and new join and sprintf functions [httpjson] Add new join and sprintf functions Sep 3, 2021
@marc-gr marc-gr requested a review from P1llus September 3, 2021 11:07
@marc-gr marc-gr merged commit 29be9df into elastic:master Sep 3, 2021
@marc-gr marc-gr deleted the httpjson-add-request-to-ctx branch September 3, 2021 12:51
mergify bot pushed a commit that referenced this pull request Sep 3, 2021
@marc-gr
Add new join and sprintf functions (#27735)
46e295b 
(cherry picked from commit 29be9df)
@mergify mergify bot mentioned this pull request Sep 3, 2021
Merged
marc-gr added a commit that referenced this pull request Sep 3, 2021
@mergify @marc-gr
Add new join and sprintf functions (#27735) (#27742)
1579f08 
(cherry picked from commit 29be9df)

Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@marc-gr
Add new join and sprintf functions (elastic#27735)
68be163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @P1llus