Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/httpjson/internal/v2: allow split chains to continue past empty targets #27880

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 13, 2021

What does this PR do?

This adds a configuration option "ignore_error" that allows a split processor chain to continue if a target field is present but empty.

Why is it important?

This is required to address #26008 by allowing multiple splits on an input (see #26008 (comment)).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files Defaults to existing behaviour.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Confirm that the new expected split processor results are correct in split_test.go

How to test this PR locally

Standard testing.

Related issues

Use cases

See related issue.

Screenshots

N/A

Logs

N/A

@efd6 efd6 requested a review from marc-gr September 13, 2021 00:08
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2021
…tinue past empty targets

This adds a configuration option "ignore_error" that allows a split
processor chain to continue if a target field is present but empty.

Updates elastic#26008
@efd6 efd6 added enhancement Team:Security-External Integrations and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-14T03:33:39.195+0000

  • Duration: 97 min 52 sec

  • Commit: 2c3ea70

Test stats 🧪

Test Results
Failed 0
Passed 8259
Skipped 1201
Total 9460

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8259
Skipped 1201
Total 9460

Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just dropped a thought

x-pack/filebeat/input/httpjson/internal/v2/split.go Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-httpjson.asciidoc Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor Author

efd6 commented Sep 14, 2021

/test

@marc-gr marc-gr added the backport-v7.16.0 Automated backport with mergify label Sep 14, 2021
@efd6 efd6 merged commit 2036ad8 into elastic:master Sep 14, 2021
@efd6 efd6 deleted the split/relax branch September 14, 2021 09:13
mergify bot pushed a commit that referenced this pull request Sep 14, 2021
…tinue past empty targets (#27880)

This adds a configuration option "ignore_empty_value" that allows a split
processor chain to continue if a target field is missing or empty.

Updates #26008

(cherry picked from commit 2036ad8)
efd6 added a commit that referenced this pull request Sep 14, 2021
…tinue past empty targets (#27880) (#27914)

This adds a configuration option "ignore_empty_value" that allows a split
processor chain to continue if a target field is missing or empty.

Updates #26008

(cherry picked from commit 2036ad8)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…tinue past empty targets (elastic#27880)

This adds a configuration option "ignore_empty_value" that allows a split
processor chain to continue if a target field is missing or empty.

Updates elastic#26008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants