Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get metricbeat to compile on AIX #27954

Merged
merged 33 commits into from
Oct 19, 2021

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Sep 15, 2021

What does this PR do?

This is a handful of updates to get metricbeat compiling on AIX. I'm not saying metricbeat works on AIX, but now it will compile.

What's in here?

  • Updates for various vendor libraries that have recent AIX support
  • A few fixes to make those newer libraries work
  • Exclusion of cloudfoundry, azure, k8s, and docker code on AIX, as those libraries currently aren't building on AIX.
  • A few build tag fixes

Why is it important?

We'd like to get this working.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry requested a review from a team September 15, 2021 20:37
@fearful-symmetry fearful-symmetry self-assigned this Sep 15, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-18T22:27:05.380+0000

  • Duration: 245 min 10 sec

  • Commit: 8fefdf9

Test stats 🧪

Test Results
Failed 0
Passed 53650
Skipped 5321
Total 58971

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2021

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021
@fearful-symmetry fearful-symmetry added backport-v7.16.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 22, 2021
@fearful-symmetry
Copy link
Contributor Author

/test

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aix-updates upstream/aix-updates
git merge upstream/master
git push upstream aix-updates

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remember to add a changelog entry.

As a side note, maybe we have to document somewhere the features that are not available for AIX, though probably nobody is going to miss Cloud foundry or Kubernetes support in these systems.

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aix-updates upstream/aix-updates
git merge upstream/master
git push upstream aix-updates

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aix-updates upstream/aix-updates
git merge upstream/master
git push upstream aix-updates

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aix-updates upstream/aix-updates
git merge upstream/master
git push upstream aix-updates

@fearful-symmetry fearful-symmetry merged commit 298d786 into elastic:master Oct 19, 2021
mergify bot pushed a commit that referenced this pull request Oct 19, 2021
* first pass at getting AIX to build

* make notice

* format libbeat files

* fix newer pgsql lib quoting

* fix build tags

* try to move around docker stat files

* add diskio targets

* remove cloudfoundry from aix

* forgot formatting, again

* get filebeat to build

* mage fmt

* fix bad import

* fix merge

* changelog

* fmt

* fix filebeat

* fix broken headers, again

* see if list_docker is fixed

* fix CI

* go mod tidy

(cherry picked from commit 298d786)

# Conflicts:
#	go.mod
#	go.sum
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
* first pass at getting AIX to build

* make notice

* format libbeat files

* fix newer pgsql lib quoting

* fix build tags

* try to move around docker stat files

* add diskio targets

* remove cloudfoundry from aix

* forgot formatting, again

* get filebeat to build

* mage fmt

* fix bad import

* fix merge

* changelog

* fmt

* fix filebeat

* fix broken headers, again

* see if list_docker is fixed

* fix CI

* go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify enhancement Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants