[Filebeat] Add experimental to journald input docs, rename two fields #28065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the docs as experimental to match the code. Also fix the regexp condition in the example config.
There was a typo in the word `capabilities` for `journald.process.capabilities`. And the mapping for syslog facility should have been to `log.syslog.facility.code` because the value is a number rather than a name.
botelastic
bot
added
the
needs_team
andrewkroh
added
backport-v7.16.0
|
Pinging @elastic/agent (Team:Agent) |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
changed the title
adriansr
approved these changes
Sep 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
…#28065) * Add the experimental tag to journald input Mark the docs as experimental to match the code. Also fix the regexp condition in the example config. * Fix journald field mappings There was a typo in the word `capabilities` for `journald.process.capabilities`. And the mapping for syslog facility should have been to `log.syslog.facility.code` because the value is a number rather than a name. (cherry picked from commit fe84ec7) # Conflicts: # journalbeat/include/fields.go
andrewkroh
added a commit
that referenced
this pull request
Sep 28, 2021
…#28065) * Add the experimental tag to journald input Mark the docs as experimental to match the code. Also fix the regexp condition in the example config. * Fix journald field mappings There was a typo in the word `capabilities` for `journald.process.capabilities`. And the mapping for syslog facility should have been to `log.syslog.facility.code` because the value is a number rather than a name.
andrewkroh
added a commit
that referenced
this pull request
Sep 30, 2021
…#28065) (#28160) * Add the experimental tag to journald input Mark the docs as experimental to match the code. Also fix the regexp condition in the example config. * Fix journald field mappings There was a typo in the word `capabilities` for `journald.process.capabilities`. And the mapping for syslog facility should have been to `log.syslog.facility.code` because the value is a number rather than a name. Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…elastic#28065) * Add the experimental tag to journald input Mark the docs as experimental to match the code. Also fix the regexp condition in the example config. * Fix journald field mappings There was a typo in the word `capabilities` for `journald.process.capabilities`. And the mapping for syslog facility should have been to `log.syslog.facility.code` because the value is a number rather than a name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the experimental tag to journald input docs. This matches the code which logs that input is experimental.
regexpcondition in the example config.journald.process.capabilitestojournald.process.capabilitiesto fix spelling.log.syslog.facility.nametolog.syslog.facility.codebecause the value is numeric rather than the facility name.Why is it important?
Set expectations of stability for the input. There will be one config change coming in the future.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.