Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud.google.com/go library #28229

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Update cloud.google.com/go library #28229

merged 2 commits into from
Oct 5, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 4, 2021

What does this PR do?

This PR updates cloud.google.com/go to a more recent version.

@ChrsMark
Update cloud.google.com/go library
dbb44ce 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2021
@ChrsMark ChrsMark mentioned this pull request Oct 4, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2021

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 4, 2021
@ChrsMark ChrsMark mentioned this pull request Oct 4, 2021
Closed
@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 4, 2021

We can upgrade to a more recent one but in order to unblock https://github.com/elastic/beats/pull/28023/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R6 we just need this version. @sayden @endorama let me know what you think about this update.

@ChrsMark ChrsMark self-assigned this Oct 4, 2021
@ChrsMark ChrsMark added :integrations Team:Integrations Label for the Integrations team labels Oct 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 4, 2021
@ChrsMark
Add changelog
dda182d 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 4, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-05T07:11:35.032+0000

  • Duration: 88 min 22 sec

  • Commit: dda182d

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 5, 2021

/test

@endorama
Copy link
Member

endorama commented Oct 5, 2021

@ChrsMark FYI I'm testing this locally right now.

endorama
endorama approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data collection works as expected, so 👍 from me

@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 5, 2021

Thank for taking the time to test it @endorama! Merging!

@ChrsMark ChrsMark merged commit 0376061 into elastic:master Oct 5, 2021
@ChrsMark ChrsMark added the backport-v7.16.0 Automated backport with mergify label Oct 5, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 5, 2021
mergify bot pushed a commit that referenced this pull request Oct 5, 2021
@ChrsMark
Update cloud.google.com/go library (#28229)
81d214b 
(cherry picked from commit 0376061)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Oct 5, 2021
Closed
@ChrsMark ChrsMark mentioned this pull request Oct 5, 2021
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Oct 5, 2021
@ChrsMark
Update cloud.google.com/go library (elastic#28229)
5d801fa 
(cherry picked from commit 0376061)
ChrsMark added a commit that referenced this pull request Oct 5, 2021
@ChrsMark
Cherry-pick #28229 to 7.x: Update cloud.google.com/go library (#28250)
8628229 
* Update cloud.google.com/go library (#28229)

(cherry picked from commit 0376061)

* Update CHANGELOG.next.asciidoc
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@ChrsMark
Update cloud.google.com/go library (elastic#28229)
88347b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

@sayden sayden Awaiting requested review from sayden

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees

@ChrsMark ChrsMark

Labels
backport-v7.16.0 Automated backport with mergify :integrations Team:Integrations Label for the Integrations team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @endorama