Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename read/write_io.ops_per_sec to read/write.iops in rds metricset #28350

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Rename read/write_io.ops_per_sec to read/write.iops in rds metricset #28350

merged 4 commits into from
Oct 18, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 11, 2021

What does this PR do?

This PR is to rename aws.rds.read_io.ops_per_sec to aws.rds.read.iops and rename aws.rds.write_io.ops_per_sec to aws.rds.write.iops in rds metricset. Also changing the field names used in dashboard/lens as well.

closes: #16079

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng self-assigned this Oct 11, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

This pull request does not have a backport label. Could you fix it @kaiyan-sheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 11, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-15T19:07:10.404+0000

  • Duration: 97 min 26 sec

  • Commit: 7e472b2

Test stats 🧪

Test Results
Failed 0
Passed 9508
Skipped 2537
Total 12045

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rds_iops_rename upstream/rds_iops_rename
git merge upstream/master
git push upstream rds_iops_rename

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rds_iops_rename upstream/rds_iops_rename
git merge upstream/master
git push upstream rds_iops_rename

@kaiyan-sheng kaiyan-sheng merged commit cc10d3f into elastic:master Oct 18, 2021
@kaiyan-sheng kaiyan-sheng deleted the rds_iops_rename branch October 18, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Change rds metricname to read.iops and write.iops
3 participants