Fix docker import generator for 1.17.1 #28374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Team:Integrations
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
reviewed
Oct 13, 2021
kvch
approved these changes
Oct 13, 2021
kvch
pushed a commit
that referenced
this pull request
Oct 13, 2021
|
Backported in #28335 |
kvch
added a commit
that referenced
this pull request
Oct 14, 2021
…28335) * Update go release version 1.17.1 (#27543) * format of conditional build tags has changed * matching of * in regexes was fixed, thus breaking some of our code: golang/go#46123 * iproute package was missing from the new Golang Docker image, thus, we had to add it for our tests * go.mod file contains separate require directive for transitive dependencies (cherry picked from commit e6839ab) * Fix build tags for Go 1.17 (#28338) * additional fixes * Disable generator tests temporarily (#28362) * Fix docker import generator for 1.17.1 (#28374) * Fix liblogparser * Update go.mod * update notice Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co> Co-authored-by: Noémi Ványi <sitbackandwait@gmail.com> Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com> Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com> Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the
list_docker.gogenerator, as 1.17 introduced a new import format. This sometimes breaks CI, depending on what you're doing.Why is it important?
This causes
mage updateandmage fmtto fight with each other.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.