-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Update step name field to use keyword and text #28452
[Heartbeat] Update step name field to use keyword and text #28452
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @justinkambic? 🙏
NOTE: |
d8da14b
to
5890805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/uptime (Team:Uptime) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
* Update step name field to use keyword and text. * Add CHANGELOG entry. (cherry picked from commit 539edc8) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go
…ord and text (#28474) * [Heartbeat] Update step name field to use keyword and text (#28452) * Update step name field to use keyword and text. * Add CHANGELOG entry. (cherry picked from commit 539edc8) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go * Update generated files for backport. Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Post FF Testing Looks good !! |
…8452) * Update step name field to use keyword and text. * Add CHANGELOG entry.
What does this PR do?
Adds keyword field to
synthetics.step.name
.Why is it important?
We need to be able to bucket based on this field in the exploratory view.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Run the example synthetics journey from the docs. You should be able to find documents using a query like:
Related issues
synthetics.step.name
as keyword as well #28430.Use cases
Makes it possible to key on
synthetics.step.name
, which is useful for a number of UI applications when displaying synthetic browser monitoring data in Kibana.Screenshots
N/A
Logs
N/A