Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Update step name field to use keyword and text #28452

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

justinkambic
Copy link
Contributor

What does this PR do?

Adds keyword field to synthetics.step.name.

Why is it important?

We need to be able to bucket based on this field in the exploratory view.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Test locally
  • Review code

How to test this PR locally

Run the example synthetics journey from the docs. You should be able to find documents using a query like:

{
  "query": {
    "bool": {
      "filter": [
        {
          "term": {
            "synthetics.step.name.keyword": "hover over products menu"
          }
        }
      ]
    }
  }
}

Related issues

Use cases

Makes it possible to key on synthetics.step.name, which is useful for a number of UI applications when displaying synthetic browser monitoring data in Kibana.

Screenshots

N/A

Logs

N/A

@justinkambic justinkambic requested a review from a team as a code owner October 14, 2021 18:14
@justinkambic justinkambic self-assigned this Oct 14, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 28430/add-keyword-field upstream/28430/add-keyword-field
git merge upstream/master
git push upstream 28430/add-keyword-field

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

This pull request does not have a backport label. Could you fix it @justinkambic? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 14, 2021
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc added backport-v7.16.0 Automated backport with mergify Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed backport-skip Skip notification from the automated backport with mergify labels Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T18:22:45.369+0000

  • Duration: 67 min 28 sec

  • Commit: 5890805

Test stats 🧪

Test Results
Failed 0
Passed 3543
Skipped 80
Total 3623

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@justinkambic justinkambic merged commit 539edc8 into elastic:master Oct 15, 2021
@justinkambic justinkambic deleted the 28430/add-keyword-field branch October 15, 2021 13:58
mergify bot pushed a commit that referenced this pull request Oct 15, 2021
* Update step name field to use keyword and text.

* Add CHANGELOG entry.

(cherry picked from commit 539edc8)

# Conflicts:
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go
justinkambic added a commit that referenced this pull request Oct 18, 2021
…ord and text (#28474)

* [Heartbeat] Update step name field to use keyword and text (#28452)

* Update step name field to use keyword and text.

* Add CHANGELOG entry.

(cherry picked from commit 539edc8)

# Conflicts:
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go

* Update generated files for backport.

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@shahzad31
Copy link
Contributor

Post FF Testing Looks good !!

Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…8452)

* Update step name field to use keyword and text.

* Add CHANGELOG entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Index synthetics.step.name as keyword as well
4 participants