Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add build scripts to CODEOWNERS #28615

Merged
merged 3 commits into from
Oct 25, 2021
Merged

chore: add build scripts to CODEOWNERS #28615

merged 3 commits into from
Oct 25, 2021

Conversation

mdelapenya
Copy link
Contributor

What does this PR do?

It adds the Observability Robots as CODEOWNERS of the build packages under dev-tools package: mage, make and packaging.

I started with Robots, but I'd see it convenient to have a dedicated team for the build system: beats-builders, beats-operations??

Why is it important?

We would like to detect changes in those file so that any functional team would need a review from the specific team marked as CODEOWNER.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Is there a more suitable team instead of the Robots?

Related issues

@mdelapenya mdelapenya self-assigned this Oct 25, 2021
@mdelapenya mdelapenya added the Team:Automation Label for the Observability productivity team label Oct 25, 2021
@mdelapenya mdelapenya requested a review from a team October 25, 2021 09:15
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

This pull request does not have a backport label. Could you fix it @mdelapenya? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 25, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 25, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-25T14:58:01.208+0000

  • Duration: 20 min 8 sec

  • Commit: a8e698a

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

v1v
v1v requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not say we, robots, are the owners but contributors, I understand there is no a well defined ownership but I prefer if the Beats team own those files.

@mdelapenya
Copy link
Contributor Author

mdelapenya commented Oct 25, 2021 •
edited
Loading

I will not say we, robots, are the owners but contributors, I understand there is no a well defined ownership but I prefer if the Beats team own those files.

I totally agree. I started with robots as a team, because there is no specific team nowadays. That's why I added @andresrc as reviewer, as we'd need to clarify who should attend PRs affecting those files.

@v1v v1v requested a review from cachedout October 25, 2021 10:03
andresrc
andresrc reviewed Oct 25, 2021
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
mdelapenya
mdelapenya commented Oct 25, 2021
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@mdelapenya mdelapenya requested a review from v1v October 25, 2021 14:53
@mdelapenya mdelapenya marked this pull request as ready for review October 25, 2021 14:53
mdelapenya
mdelapenya commented Oct 25, 2021
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@mdelapenya mdelapenya added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 25, 2021
@mdelapenya mdelapenya merged commit 2c927f0 into elastic:master Oct 25, 2021
mergify bot pushed a commit that referenced this pull request Oct 25, 2021
@mdelapenya
chore: add build scripts to CODEOWNERS (#28615)
59dc087 
* chore: add build scripts to CODEOWNERS

* chore: use Beats main team

* chore: follow same path syntax

(cherry picked from commit 2c927f0)

# Conflicts:
#	.github/CODEOWNERS
@mergify mergify bot mentioned this pull request Oct 25, 2021
Merged
mergify bot pushed a commit that referenced this pull request Oct 25, 2021
@mdelapenya
chore: add build scripts to CODEOWNERS (#28615)
36ecec9 
* chore: add build scripts to CODEOWNERS

* chore: use Beats main team

* chore: follow same path syntax

(cherry picked from commit 2c927f0)

# Conflicts:
#	.github/CODEOWNERS
@mergify mergify bot mentioned this pull request Oct 25, 2021
Merged
mdelapenya added a commit that referenced this pull request Oct 25, 2021
@mergify @mdelapenya
[7.16](backport #28615) chore: add build scripts to CODEOWNERS (#28626)
b0e1a36 
* chore: add build scripts to CODEOWNERS (#28615)

* chore: add build scripts to CODEOWNERS

* chore: use Beats main team

* chore: follow same path syntax

(cherry picked from commit 2c927f0)

# Conflicts:
#	.github/CODEOWNERS

* fix: resolve conflicts

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Oct 25, 2021
@mergify @mdelapenya
[7.15](backport #28615) chore: add build scripts to CODEOWNERS (#28625)
1a641a2 
* chore: add build scripts to CODEOWNERS (#28615)

* chore: add build scripts to CODEOWNERS

* chore: use Beats main team

* chore: follow same path syntax

(cherry picked from commit 2c927f0)

# Conflicts:
#	.github/CODEOWNERS

* fix: resolve conflicts

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@mdelapenya mdelapenya deleted the build-codeowners branch October 26, 2021 05:17
v1v added a commit to v1v/beats that referenced this pull request Oct 26, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/remove-jo…
fcc08d9 
…urnalbeat-ci

* upstream/master: (49 commits)
  [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589)
  fix: use declarative style for complete variant of the elastic-agent (elastic#28526)
  x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609)
  docs: Update `api_key` example on elasticsearch output (elastic#28606)
  chore: add build scripts to CODEOWNERS (elastic#28615)
  Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622)
  Add note about changes to regexp package in Golang (elastic#28616)
  CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612)
  Osquerybeat: Fix extenstion unable to start on windows (elastic#28598)
  Osquerybeat: Return the query result count with the action response (elastic#28576)
  Agent: Allow custom response properties in the action response (elastic#28575)
  [Heartbeat] Only setuid in elastic-agent image (elastic#28577)
  Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530)
  CI: refactor the run e2e build (elastic#28502)
  Use fsnotify with long windows name-safe changes (elastic#28517)
  Remove unneeded mergify config
  backport: Add 7.16 branch (elastic#28560)
  Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533)
  Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434)
  [Heartbeat] Make run_once syntax a boolean (elastic#28548)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@mdelapenya
chore: add build scripts to CODEOWNERS (elastic#28615)
33dee3e 
* chore: add build scripts to CODEOWNERS

* chore: use Beats main team

* chore: follow same path syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresrc andresrc andresrc left review comments

@v1v v1v v1v approved these changes

@jsoriano jsoriano jsoriano approved these changes

@cachedout cachedout Awaiting requested review from cachedout

Assignees

@mdelapenya mdelapenya

Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdelapenya @elasticmachine @jsoriano @andresrc @v1v