Mark logging.ecs and json as deprecated #28772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
docs
v7.16.0
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Maybe add a |
michel-laterman
force-pushed
the
deprecate-logging-attributes
branch
from
33d424e
to
fb9c033
Compare
|
@kvch there will be a circular dependency if I try to use |
dedemorton
approved these changes
Nov 3, 2021
|
🤦 |
|
Then how about noting the deprecation in the configuration files as well? |
kvch
approved these changes
Nov 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mark
logging.ecsandlogging.jsonas deprecated for thev7.16.0release.These attributes will no longer be used in 8.0.
Why is it important?
These settings will be removed for 8.0 as part of the work to get all components producing ECS logs by default.
The PR is #28573
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues