-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] support credentials_json in gcp module #29584
[Metricbeat] support credentials_json in gcp module #29584
Conversation
This pull request does not have a backport label. Could you fix it @endorama? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
e688a00
to
6158887
Compare
Pinging @elastic/integrations (Team:Integrations) |
What does this PR do?
Adds support for
credentials_json
metricset configuration parameter togcp.billing
andgcp.metrics
metricset.Why is it important?
This change is required to support at metricset level this parameter that is already supported in Kibana Integration UI.
Filebeat
gcp
inputs support this parameter and due to the limitations in Kibana is not possible to use input level variables but globals are required. This PR fixes this in order to prevent having a configuration parameter in the UI that is not used by inputs.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
x-pack/metricbeat
gcp
module with:credentials_json
Related issues
Use cases
Screenshots
Logs