Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #28954 to 7.17: Add kubernetes job name as the controller #29679

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Cherry-pick #28954 to 7.17: Add kubernetes job name as the controller #29679

merged 2 commits into from
Jan 11, 2022

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Jan 4, 2022 •
edited by zube bot
Loading

Cherry-pick of PR #28954 to 7.17 branch. Original message:

What does this PR do?

This PR adds kubernetes.job.name in Pods' metadata.

Why is it important?

It enriches the documents of pods belonging to Jobs with the Job name.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Similar issue where metadata was added for daemonsets #26808

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 4, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 4, 2022
@tetianakravchenko tetianakravchenko mentioned this pull request Jan 4, 2022
Merged
6 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 4, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-10T16:52:51.044+0000

  • Duration: 64 min 3 sec

  • Commit: 3aa240e

Test stats 🧪

Test Results
Failed 0
Passed 37978
Skipped 4436
Total 42414

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tetianakravchenko
Copy link
Contributor Author

/test

@tetianakravchenko tetianakravchenko self-assigned this Jan 5, 2022
@tetianakravchenko
Copy link
Contributor Author

/test

wilsonge and others added 2 commits January 10, 2022 14:58
@wilsonge @tetianakravchenko
Add kubernetes job name as the controller (elastic#28954)
c523157 
(cherry picked from commit eaa3b32)
@tetianakravchenko
remove not relevand changelog records
3aa240e 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Contributor Author

/test

@tetianakravchenko
Copy link
Contributor Author

/package

1 similar comment
@tetianakravchenko
Copy link
Contributor Author

/package

@tetianakravchenko tetianakravchenko merged commit 685883f into elastic:7.17 Jan 11, 2022
@tetianakravchenko tetianakravchenko deleted the backport_28954_7.17 branch January 11, 2022 11:02
@zube zube bot removed the [zube]: Done label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

Assignees

@tetianakravchenko tetianakravchenko

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetianakravchenko @elasticmachine @MichaelKatsoulis @wilsonge