Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes in the artifact build from #29890 #30007

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Revert changes in the artifact build from #29890 #30007

merged 1 commit into from
Jan 26, 2022

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 25, 2022 •
edited by lykkin
Loading

Revert changes introduced in #29890 that prevented all the artifacts to
be build.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Revert changes in the artifact build from #29890
79b58d5 
Revert changes introduced in #29890 that prevented all the artifacts to
be build.
@ph ph added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 25, 2022
@ph ph requested a review from AndersonQ January 25, 2022 22:04
@ph ph requested a review from a team as a code owner January 25, 2022 22:04
@ph ph self-assigned this Jan 25, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 25, 2022
@ph
Copy link
Contributor Author

ph commented Jan 25, 2022

/package

@ph ph added the build-system Issue or change affecting Mage, Make, or build scripts. label Jan 25, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-25T22:04:36.489+0000

  • Duration: 117 min 1 sec

  • Commit: 79b58d5

Test stats 🧪

Test Results
Failed 0
Passed 47950
Skipped 4285
Total 52235

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ph ph merged commit a563681 into elastic:master Jan 26, 2022
@ph ph deleted the fix/build-all-artifacts branch January 26, 2022 00:46
@v1v
Copy link
Member

v1v commented Jan 26, 2022

It broke the packaging

image

@efd6 efd6 mentioned this pull request Jan 26, 2022
Merged
7 tasks
@ph
Copy link
Contributor Author

ph commented Jan 27, 2022

fixed in #30039

I need to recheck how ci, works, ~180 were green when it was merged.

@cmacknz cmacknz mentioned this pull request Jan 27, 2022
Merged
6 tasks
@v1v
Copy link
Member

v1v commented Jan 27, 2022 •
edited
Loading

I need to recheck how ci, works, ~180 were green when it was merged.

The packaging is notrunning anymore by default as part of the main pipeline. It only gets run if changes in a particular folder:

I guess, dev-tools/mage/crossbuild.go should be also included in the list or maybe a more generic pattern match with dev-tools/mage/*

@AndersonQ AndersonQ mentioned this pull request Jan 28, 2022
Merged
yashtewari pushed a commit to build-security/beats that referenced this pull request Jan 30, 2022
@ph @yashtewari
Revert changes in the artifact build from elastic#29890 (elastic#30007)
da06966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lykkin lykkin lykkin approved these changes

@michel-laterman michel-laterman michel-laterman approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees

@ph ph

Labels
backport-skip Skip notification from the automated backport with mergify build-system Issue or change affecting Mage, Make, or build scripts. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ph @elasticmachine @v1v @lykkin @michel-laterman