HAProxy improvements #3003
Merged
HAProxy improvements #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
ruflin
force-pushed
the
mb-haproxy-improvements
branch
3 times, most recently
from
7eea26d to
8ee402e
Compare
ruflin
added
review
and removed
in progress
ruflin
force-pushed
the
mb-haproxy-improvements
branch
from
8ee402e to
93300e4
Compare
Restructure info and stats metricset
ruflin
force-pushed
the
mb-haproxy-improvements
branch
from
93300e4 to
e88749d
Compare
|
jenkins, retest it |
andrewkroh
approved these changes
Nov 18, 2016
| // As a minimum it must inherit the mb.BaseMetricSet fields, but can be extended with | ||
| // additional entries. These variables can be used to persist data or configuration between | ||
| // multiple fetch calls. | ||
| // MetricSet for haproxy info |
There was a problem hiding this comment.
Please 🙏 end all godocs with periods. Then no one has to wonder if you forgot to write the end of the sentence. 😼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure info and stats metricset
I didn't add dashboards yet. When we add dashboard it might get some more insights if there are some values we need / don't need. That is the reason I kept it experimental.