-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mutex to listinfInfo #30131
add mutex to listinfInfo #30131
Conversation
This pull request does not have a backport label. Could you fix it @aspacca? 🙏
NOTE: |
Pinging @elastic/integrations (Team:Integrations) |
This pull request does not have a backport label. Could you fix it @aspacca? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative to locking that might want to be considered is to use atomic. That adds complexity though.
I switched to atomic approach as suggested
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the I think the inequality used for updating listingInfo.finalCheck
should be more careful (already existing code).
* add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2)
* add mutex to listinfInfo (#30131) * add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2) * clean changelog Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
* add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2)
* add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2)
* add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2) Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
* add mutex to listinfInfo (#30131) * add mutex to listinfInfo * back to mutex * add warn logging for totObject not matchig sum of storedObjects and errorObjects in listingInfo * changelog * fix merge (cherry picked from commit ce2e5c2) * fix changelog Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
Bug
What does this PR do?
Add a mutex to
listingInfo
used by states in the s3 poller filebeat inputWhy is it important?
see #30123
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Closes #30123
Use cases
Screenshots
Logs