Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql-doc updated with the list of tables which should have permission #30137

Merged
merged 1 commit into from
Feb 1, 2022
Merged

mssql-doc updated with the list of tables which should have permission #30137

merged 1 commit into from
Feb 1, 2022

Conversation

ManojS-shetty
Copy link
Contributor

@ManojS-shetty ManojS-shetty commented Feb 1, 2022

What does this PR do?

This PR is a update for MSSQL module document with additional information like permission required for the list of tables.

Why is it important?

These information are needed for the users to know about prerequisites.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [NA]

How to test this PR locally

NA

Related issues

Use cases

Screenshots

Logs

@ManojS-shetty ManojS-shetty added docs Team:Integrations Label for the Integrations team labels Feb 1, 2022
@ManojS-shetty ManojS-shetty self-assigned this Feb 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

This pull request does not have a backport label. Could you fix it @ManojS-shetty? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 1, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-01T13:29:17.622+0000

  • Duration: 24 min 11 sec

  • Commit: 22e9cca

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@ManojS-shetty ManojS-shetty merged commit 174ada3 into elastic:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify docs Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Update MSSQL docs
3 participants