Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fix #30439

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

matschaffer
Copy link
Contributor

What does this PR do?

Fixes doc spelling

Why is it important?

Amusingly enough docker only errors out if the image hasn't been pulled already.

So I'd been running and ineffective --pull allways and only noticed once I'd cleaned out a bunch of old docker images.

Amusingly enough docker only errors out if the image hasn't been pulled already.

So I'd been running and ineffective `--pull allways` and only noticed once I'd cleaned out a bunch of old docker images.
@matschaffer matschaffer added docs Filebeat Filebeat Team:Integrations Label for the Integrations team labels Feb 17, 2022
@matschaffer matschaffer self-assigned this Feb 17, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

This pull request does not have a backport label. Could you fix it @matschaffer? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 17, 2022
@matschaffer matschaffer requested a review from jsoriano February 17, 2022 04:07
@matschaffer matschaffer added backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 17, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-17T04:07:23.069+0000

  • Duration: 20 min 1 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@matschaffer matschaffer merged commit e98703c into elastic:main Feb 21, 2022
@matschaffer matschaffer deleted the doc-module-dev-fix-spelling branch February 21, 2022 01:24
@matschaffer matschaffer restored the doc-module-dev-fix-spelling branch February 21, 2022 01:24
@matschaffer matschaffer deleted the doc-module-dev-fix-spelling branch February 21, 2022 01:24
@matschaffer matschaffer restored the doc-module-dev-fix-spelling branch February 21, 2022 01:24
@matschaffer matschaffer deleted the doc-module-dev-fix-spelling branch February 21, 2022 01:24
mergify bot pushed a commit that referenced this pull request Feb 21, 2022
(cherry picked from commit e98703c)

# Conflicts:
#	docs/devguide/modules-dev-guide.asciidoc
mergify bot pushed a commit that referenced this pull request Feb 21, 2022
(cherry picked from commit e98703c)
mergify bot pushed a commit that referenced this pull request Feb 21, 2022
(cherry picked from commit e98703c)
@matschaffer matschaffer removed the backport-7.17 Automated backport to the 7.17 branch with mergify label Feb 21, 2022
matschaffer added a commit that referenced this pull request Feb 21, 2022
Co-authored-by: Mat Schaffer <mat@elastic.co>
matschaffer added a commit that referenced this pull request Feb 21, 2022
Co-authored-by: Mat Schaffer <mat@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
…nd-k8s-env

* upstream/main:
  fix typos and improve sentences (elastic#30432)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440)
  {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321)
  Spelling fix (elastic#30439)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438)
  Add BC about Homebrew no longer being available in 8.0 (elastic#30419)
  Install gawk as a replacement for mawk in Docker containers. (elastic#30452)
  Clean up python-related system tests (elastic#30415)
  Fix TestNewModuleRegistry flakiness (elastic#30453)
  [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382)
  Set `log.offset` to the start of the reported line in filestream (elastic#30445)
  clarify SelectedPackageTypes meaning and improve its usage (elastic#30142)
  [elasticsearch module] serialize shards properties (elastic#30408)
  Add docs about hints and templates autodiscovery priority (elastic#30343)
v1v added a commit to v1v/beats that referenced this pull request Feb 22, 2022
…ckaging-docker

* upstream/main: (26 commits)
  Update docker/distribution to 2.8.0 (elastic#30462)
  Add `parsers` examples to `filestream` reference configuration (elastic#30529)
  extend documentation about setting orchestrator.cluster fields (elastic#30518)
  Forward-port 8.0.1 changelog to main (elastic#30522)
  Switch skip to use `CI` (elastic#30512)
  packetbeat/beater: don't attempt to install npcap when already installed (elastic#30509)
  Fix Docker module: rename fields on dashboards (elastic#30500)
  fix typos and improve sentences (elastic#30432)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440)
  {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321)
  Spelling fix (elastic#30439)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438)
  Add BC about Homebrew no longer being available in 8.0 (elastic#30419)
  Install gawk as a replacement for mawk in Docker containers. (elastic#30452)
  Clean up python-related system tests (elastic#30415)
  Fix TestNewModuleRegistry flakiness (elastic#30453)
  [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382)
  Set `log.offset` to the start of the reported line in filestream (elastic#30445)
  clarify SelectedPackageTypes meaning and improve its usage (elastic#30142)
  [elasticsearch module] serialize shards properties (elastic#30408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify docs Filebeat Filebeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants