Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Winlogbeat] Improve registry error message #30543

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 22, 2022

What does this PR do?

If the registry file is invalid for some reason the error can be ambiguous given that
the config file is also in YAML. So give the errors more context. This is an example
of the ambiguous error:

Exiting: yaml: control characters are not allowed

Why is it important?

The original error message was confusing.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh andrewkroh added bug Winlogbeat backport-v8.2.0 Automated backport with mergify labels Feb 22, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 22, 2022
@andrewkroh andrewkroh force-pushed the bugfix/wlb/registy-yaml-error branch from 0134785 to 6b180c5 Compare February 22, 2022 18:23
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-22T19:03:44.643+0000

  • Duration: 67 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 818
Skipped 15
Total 833

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 22, 2022
@andrewkroh andrewkroh requested a review from a team February 22, 2022 18:59
If the registry file is invalid for some reason the error can be ambiguous given that
the config file is also in YAML. So give the errors more context. This is an example
of the ambiguous error:

    Exiting: yaml: control characters are not allowed
@andrewkroh andrewkroh force-pushed the bugfix/wlb/registy-yaml-error branch from 6b180c5 to e77e872 Compare February 22, 2022 19:03
@andrewkroh andrewkroh merged commit b33c45e into elastic:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.2.0 Automated backport with mergify bug Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants